PHOENIX-6216 Add Omid and Tephra support to create-release script #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
ankitsinghal
approved these changes
Nov 13, 2020
| @@ -52,6 +52,11 @@ RUN wget -qO- "https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&fi | |||
| tar xvz -C /opt | |||
| ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION} | |||
|
|
|||
| # Install protobuf-2.5 protoc binary from maven central, as that seems to be the only binary available | |||
| RUN mkdir /opt/protobuf-2.5.0 | |||
There was a problem hiding this comment.
Not particular to this change, but I hope Omid dependency on protobuf 2.5.0 doesn't conflict with the protobuf 3.0+ in Hadoop/HBase/Phoenix runtime.
There was a problem hiding this comment.
It doesn't make the HBase protobuf version mess any worse than it already is :)
We use unshaded 2.5 for the coprocessor api, just as in Phoenix.
| #Omid has an even more nonstandard maven structure, and needs more hacks | ||
| for i in hbase-shims/hbase-*; do | ||
| if [ -e "$i" ]; then | ||
| sed -i -e "0,\#<version>.*</version>#{s##<version>${this_version}</version>#}" $i/pom.xml |
There was a problem hiding this comment.
I tried to find the alternative with options in the version maven plugin to update multi-level parent-child relationship but it seems we have no option other than this hack
There was a problem hiding this comment.
Long term we should fix the build to build both set of artifacts in one pass, like connectors and tephra does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.