PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h indexes MutationState.join() ignores index rows in row count so totalRowCount calculated will reflect the data table always and the index table only if the bestPlan uses the index table. So ignore the other index tables when determining the number of tables updated.
|
A few questions for this.
|
|
Another question, I see the JIRA does not make a difference between sever and client side deletions. Did we test both paths? I'm assuming the new ITs hit the client path but I don't see any assertion of that. |
|
Last questions what is the impact to changing the output of MutationState::getUpdateCount() in the paths where that is used? Its not clear to me, I tried to follow the change but only went to the writing of the tuple in one of the iterators... |
The bug is only for client side deletes. I updated the jira title to reflect that |
@dbwong are you suggesting to change MutationState to report row count for all updated tables ? |
The tests for immutable tables is parameterized on transactions and local indexes. In the new tests that I added I have skipped the transactions but I can remove that check. @dbwong I didn't understand what you meant by handling projected tables. Can you please elaborate ? |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This way we don't have to fix the inflated row count by dividing the number of tables updated. Works for DELETE queries with and without LIMIT filter.
|
💔 -1 overall
This message was automatically generated. |
gjacoby126
requested changes
Nov 12, 2020
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
Show resolved
Hide resolved
tkhurana
force-pushed
the
PHOENIX-6218-4.x
branch
from
f7f744a
to
a511e38
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@tkhurana - 4 of the 5 test failures are just timeouts, but could you please verify that UpsertSelectIT passes locally for you? That failure's coming from a failed assertion. Thanks! |
@gjacoby126 Yes, it is passing locally. |
|
@tkhurana - I merged into 4.x, could you please also make a version for master? |
swaroopak
pushed a commit
that referenced
this pull request
Dec 14, 2020
…h indexes (#961) * PHOENIX-6218 Rows deleted count is incorrect for immutable tables with indexes Signed-off-by: Swaroopa Kadam <s.kadam@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MutationState.join() ignores index rows in row count so totalRowCount calculated
will reflect the data table always and the index table only if the bestPlan
uses the index table. So ignore the other index tables when determining
the number of tables updated.