Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix 6223 could not find or load main class sqline.SqLine #969

Closed
wants to merge 2 commits into from

Conversation

litianmei
Copy link

No description provided.

@stoty
Copy link
Contributor

stoty commented Nov 16, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 pylint 0m 5s There were no new pylint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
1m 25s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #969
Optional Tests dupname asflicense pylint
uname Linux b61046349a7b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 5ff3edb
Max. process+thread count 51 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/1/console
versions git=2.7.4 maven=3.3.9 pylint=2.4.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

Comments from #965 are applicable here. One follow up question from the thread on #965 : Which command do you use to build phoenix-client jar?
Even with mvn clean install -DskipTests at project level, we should get phoenix-client.jar as symlink to phoenix-client-{version}.jar under phoenix-client-parent/phoenix-client/target/. Could you please try once?

@@ -77,7 +77,7 @@ def findClasspath(command_name):
return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read())

def setPath():
PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar"
PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar"
Copy link
Contributor

@stoty stoty Nov 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will still match sources:

$ls -l phoenix-client*[!s][!t].jar
-rw-r--r-- 1 stoty staff 75651719 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar

This would not:

$]ls -l phoenix-client*[!s].jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified it,please have a look

@stoty
Copy link
Contributor

stoty commented Nov 27, 2020

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
_ Patch Compile Tests _
+1 💚 pylint 0m 5s There were no new pylint issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
1m 26s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #969
Optional Tests dupname asflicense pylint
uname Linux a61cde138491 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 457a67c
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-969/2/console
versions git=2.7.4 maven=3.3.9 pylint=2.4.4
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants