-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phoenix 6223 could not find or load main class sqline.SqLine #969
Conversation
🎊 +1 overall
This message was automatically generated. |
Comments from #965 are applicable here. One follow up question from the thread on #965 : Which command do you use to build phoenix-client jar? |
bin/phoenix_utils.py
Outdated
@@ -77,7 +77,7 @@ def findClasspath(command_name): | |||
return tryDecode(subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout.read()) | |||
|
|||
def setPath(): | |||
PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar" | |||
PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will still match sources:
$ls -l phoenix-client*[!s][!t].jar
-rw-r--r-- 1 stoty staff 75651719 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
This would not:
$]ls -l phoenix-client*[!s].jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04 phoenix-client-5.1.0-SNAPSHOT.jar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified it,please have a look
abf7d82
to
723ca79
Compare
🎊 +1 overall
This message was automatically generated. |
No description provided.