PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI… #975

yanxinyi · 2020-11-19T06:11:55Z

…EW_TTL has expired

stoty · 2020-11-19T06:18:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 0s	Docker mode activated.
-1 ❌	docker	5m 56s	Docker failed to build yetus/phoenix:955047a0b.

Subsystem	Report/Notes
GITHUB PR	#975
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/1/console
versions	git=2.17.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jpisaac

A few more files remaining to review.

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixMultiViewInputFormat.java

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixMultiViewInputSplit.java

...ore/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java

jpisaac · 2020-11-20T16:44:10Z

...ore/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java

+                            // CASE 2 : BASE_TABLE -> VIEW
+                            PTable parentTable = PhoenixRuntime.getTable(connection, null,
+                                    pTable.getParentName().toString());
+                            if (parentTable.getType() == PTableType.VIEW &&


Can u add comments here please?

jpisaac · 2020-11-20T16:46:15Z

...ore/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java

+                        PTable pTable = null;
+                        try {
+                            pTable = PhoenixRuntime.getTable(connection, tenantId, fullTableName);
+                            // we currently only support up to three levels


Why only upto 3 levels?

actually, we do support multi-levels other than 3, let me remove this.

jpisaac · 2020-11-20T16:50:41Z

...ore/src/main/java/org/apache/phoenix/mapreduce/util/DefaultPhoenixMultiViewListProvider.java

+                        }
+                    }
+                    if (isQueryMore) {
+                        if (fullTableName == null) {


fullTableName is not being used anywhere after this, so why the check?

the fullTableName is checking whether we done the full scan of syscat or not.
If we do have more rows to query, the current fullTableName cannot be null right? If we don't have more rows to scan, the current rs.next will not have any value, and we reset the fullTableName value to null for every iteration.

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java

stoty · 2020-11-21T03:43:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 29s	4.x passed
+1 💚	compile	0m 55s	4.x passed
+1 💚	checkstyle	0m 50s	4.x passed
+1 💚	javadoc	0m 43s	4.x passed
+0 🆗	spotbugs	2m 56s	phoenix-core in 4.x has 950 extant spotbugs warnings.
-0 ⚠️	patch	3m 3s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 22s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
-1 ❌	checkstyle	1m 1s	phoenix-core: The patch generated 536 new + 1101 unchanged - 14 fixed = 1637 total (was 1115)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 42s	the patch passed
-1 ❌	spotbugs	3m 15s	phoenix-core generated 9 new + 950 unchanged - 0 fixed = 959 total (was 950)
		_ Other Tests _
-1 ❌	unit	136m 49s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		174m 3s

Reason	Tests
FindBugs	module:phoenix-core
	Dead store to listOfInputSplit in org.apache.phoenix.mapreduce.PhoenixMultiViewInputFormat.getSplits(JobContext) At PhoenixMultiViewInputFormat.java:org.apache.phoenix.mapreduce.PhoenixMultiViewInputFormat.getSplits(JobContext) At PhoenixMultiViewInputFormat.java:[line 52]
	Boxed value is unboxed and then immediately reboxed in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection, PTable, String, Configuration, Mapper$Context, ViewInfoTracker) At PhoenixTTLDeleteJobMapper.java:then immediately reboxed in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection, PTable, String, Configuration, Mapper$Context, ViewInfoTracker) At PhoenixTTLDeleteJobMapper.java:[line 159]
	Invocation of toString on Throwable.getStackTrace() in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.initMultiViewJobStatusTracker(Configuration) At PhoenixTTLDeleteJobMapper.java:in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.initMultiViewJobStatusTracker(Configuration) At PhoenixTTLDeleteJobMapper.java:[line 70]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[]) At PhoenixTTLTool.java:org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[]) At PhoenixTTLTool.java:[line 113]
	Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 182]
	Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:[line 39]
	Exception is caught when Exception is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:[line 141]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481]
Failed junit tests	phoenix.end2end.DropIndexedColsIT
	phoenix.end2end.index.GlobalMutableNonTxIndexIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#975
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 2797e9a950bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `e57fcc8`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/testReport/
Max. process+thread count	6596 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2020-11-25T09:04:00Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 26s	4.x passed
+1 💚	compile	1m 10s	4.x passed
+1 💚	checkstyle	0m 53s	4.x passed
+1 💚	javadoc	0m 53s	4.x passed
+0 🆗	spotbugs	3m 55s	phoenix-core in 4.x has 950 extant spotbugs warnings.
-0 ⚠️	patch	4m 3s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 31s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
-1 ❌	checkstyle	1m 1s	phoenix-core: The patch generated 526 new + 1110 unchanged - 5 fixed = 1636 total (was 1115)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 51s	the patch passed
-1 ❌	spotbugs	4m 10s	phoenix-core generated 7 new + 950 unchanged - 0 fixed = 957 total (was 950)
		_ Other Tests _
-1 ❌	unit	215m 47s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 32s	The patch does not generate ASF License warnings.
		255m 58s

Reason	Tests
FindBugs	module:phoenix-core
	Boxed value is unboxed and then immediately reboxed in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection, ViewInfoTracker, Configuration, Mapper$Context) At PhoenixTTLDeleteJobMapper.java:then immediately reboxed in org.apache.phoenix.mapreduce.PhoenixTTLDeleteJobMapper.deleteExpiredRows(PhoenixConnection, ViewInfoTracker, Configuration, Mapper$Context) At PhoenixTTLDeleteJobMapper.java:[line 146]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[]) At PhoenixTTLTool.java:org.apache.phoenix.mapreduce.PhoenixTTLTool.parseArgs(String[]) At PhoenixTTLTool.java:[line 115]
	Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 184]
	Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:[line 39]
	Exception is caught when Exception is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:[line 141]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481]
Failed junit tests	TEST-[GroupByIT_0]
	TEST-[IntArithmeticIT_0]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#975
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux e553143007c3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `c3818ee`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/testReport/
Max. process+thread count	5977 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/ViewInfoWritable.java

…line exceed more than 100 char"

jpisaac

Mostly LGTM, except for some nits,
Also, can u add some unit tests for most of the framework classes?

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixTTLTool.java

jpisaac · 2020-11-25T18:05:31Z

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/DefaultMultiViewSplitStrategy.java

+    public List<InputSplit> generateSplits(List<ViewInfoWritable> views, Configuration configuration) {
+        int numViewsInSplit = PhoenixConfigurationUtil.getMultiViewSplitSize(configuration);
+
+        if (numViewsInSplit < 1) {


Sorry, my bad!!

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java

phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixTTLToolIT.java

stoty · 2020-11-26T03:36:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 16s	4.x passed
+1 💚	compile	0m 58s	4.x passed
+1 💚	checkstyle	0m 52s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	3m 28s	phoenix-core in 4.x has 950 extant spotbugs warnings.
-0 ⚠️	patch	3m 36s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 36s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
-1 ❌	checkstyle	1m 5s	phoenix-core: The patch generated 524 new + 1101 unchanged - 14 fixed = 1625 total (was 1115)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 49s	the patch passed
-1 ❌	spotbugs	3m 32s	phoenix-core generated 5 new + 950 unchanged - 0 fixed = 955 total (was 950)
		_ Other Tests _
-1 ❌	unit	147m 2s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		181m 22s

Reason	Tests
FindBugs	module:phoenix-core
	Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185]
	Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.generateSplits(List, Configuration) At DefaultMultiViewSplitStrategy.java:[line 40]
	Exception is caught when Exception is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:is not thrown in org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getPhoenixMultiViewList(Configuration) At DefaultPhoenixMultiViewListProvider.java:[line 139]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481]
Failed junit tests	phoenix.end2end.index.ViewIndexIT
	phoenix.end2end.UpsertSelectIT
	phoenix.end2end.index.GlobalIndexOptimizationIT
	TEST-[RangeScanIT_0]
	phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#975
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux d99da53f93ef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `7ac4dff`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/testReport/
Max. process+thread count	6562 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

yanxinyi · 2020-11-26T07:22:59Z

Mostly LGTM, except for some nits,
Also, can u add some unit tests for most of the framework classes?

Added more tests

stoty · 2020-11-26T10:27:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 42s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 2 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	13m 9s	4.x passed
+1 💚	compile	1m 25s	4.x passed
+1 💚	checkstyle	1m 5s	4.x passed
+1 💚	javadoc	1m 1s	4.x passed
+0 🆗	spotbugs	4m 12s	phoenix-core in 4.x has 950 extant spotbugs warnings.
-0 ⚠️	patch	4m 20s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 36s	the patch passed
+1 💚	compile	1m 20s	the patch passed
+1 💚	javac	1m 20s	the patch passed
-1 ❌	checkstyle	1m 12s	phoenix-core: The patch generated 541 new + 1101 unchanged - 14 fixed = 1642 total (was 1115)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 57s	the patch passed
-1 ❌	spotbugs	4m 18s	phoenix-core generated 5 new + 950 unchanged - 0 fixed = 955 total (was 950)
		_ Other Tests _
-1 ❌	unit	146m 32s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		187m 15s

Reason	Tests
FindBugs	module:phoenix-core
	Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185]
	Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:[line 58]
	org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getTenantOrViewMultiViewList(Configuration) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:[line 110] is not discharged
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481]
Failed junit tests	phoenix.end2end.join.SortMergeJoinLocalIndexIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#975
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux a4554af1ffeb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `7ac4dff`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/testReport/
Max. process+thread count	6726 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/5/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2020-12-04T00:35:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 4 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 14s	4.x passed
+1 💚	compile	0m 57s	4.x passed
+1 💚	checkstyle	0m 54s	4.x passed
+1 💚	javadoc	0m 44s	4.x passed
+0 🆗	spotbugs	3m 4s	phoenix-core in 4.x has 950 extant spotbugs warnings.
-0 ⚠️	patch	3m 11s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 45s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
-1 ❌	checkstyle	1m 10s	phoenix-core: The patch generated 532 new + 1111 unchanged - 4 fixed = 1643 total (was 1115)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
-1 ❌	spotbugs	3m 12s	phoenix-core generated 5 new + 950 unchanged - 0 fixed = 955 total (was 950)
		_ Other Tests _
-1 ❌	unit	134m 34s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 42s	The patch does not generate ASF License warnings.
		167m 25s

Reason	Tests
FindBugs	module:phoenix-core
	Possible null pointer dereference of cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:cmdLine in org.apache.phoenix.mapreduce.PhoenixTTLTool.parseOptions(String[]) on exception path Dereferenced at PhoenixTTLTool.java:[line 185]
	Integral value cast to double and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:and then passed to Math.ceil in org.apache.phoenix.mapreduce.util.DefaultMultiViewSplitStrategy.getNumberOfMappers(int, int) At DefaultMultiViewSplitStrategy.java:[line 58]
	org.apache.phoenix.mapreduce.util.DefaultPhoenixMultiViewListProvider.getTenantOrViewMultiViewList(Configuration) may fail to clean up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:up java.sql.ResultSet Obligation to clean up resource created at DefaultPhoenixMultiViewListProvider.java:[line 110] is not discharged
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewQueryMoreSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 451]
	Boxing/unboxing to parse a primitive org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:org.apache.phoenix.mapreduce.util.PhoenixConfigurationUtil.getMultiViewSplitSize(Configuration) At PhoenixConfigurationUtil.java:[line 481]
Failed junit tests	phoenix.end2end.DeleteIT
	phoenix.end2end.DropIndexedColsIT
	phoenix.end2end.AlterMultiTenantTableWithViewsIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#975
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 7ca47fdc3495 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `5e70f76`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/testReport/
Max. process+thread count	6693 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-975/6/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

jpisaac

LGTM +1

PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI…

23a7ae4

…EW_TTL has expired

jpisaac requested changes Nov 20, 2020

View reviewed changes

handled some nits

019ef07

added diff mapper count for view and view index

b65b198

jpisaac reviewed Nov 25, 2020

View reviewed changes

phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/ViewInfoWritable.java Outdated Show resolved Hide resolved

changed view info job state in progression order and fixed number of …

f943459

…line exceed more than 100 char"

jpisaac requested changes Nov 26, 2020

View reviewed changes

added more tests and handled nits

d9b747b

added more tests

bb0e9c0

jpisaac approved these changes Dec 4, 2020

View reviewed changes

yanxinyi closed this Dec 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI… #975

PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI… #975

yanxinyi commented Nov 19, 2020

stoty commented Nov 19, 2020

jpisaac left a comment

jpisaac Nov 20, 2020

yanxinyi Nov 21, 2020

jpisaac Nov 20, 2020

yanxinyi Nov 21, 2020

jpisaac Nov 20, 2020

yanxinyi Nov 20, 2020

stoty commented Nov 21, 2020

stoty commented Nov 25, 2020

jpisaac left a comment

jpisaac Nov 25, 2020

stoty commented Nov 26, 2020

yanxinyi commented Nov 26, 2020

stoty commented Nov 26, 2020

stoty commented Dec 4, 2020

jpisaac left a comment

PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI… #975

PHOENIX-5592 MapReduce job to asynchronously delete rows where the VI… #975

Conversation

yanxinyi commented Nov 19, 2020

stoty commented Nov 19, 2020

jpisaac left a comment

Choose a reason for hiding this comment

jpisaac Nov 20, 2020

Choose a reason for hiding this comment

yanxinyi Nov 21, 2020

Choose a reason for hiding this comment

jpisaac Nov 20, 2020

Choose a reason for hiding this comment

yanxinyi Nov 21, 2020

Choose a reason for hiding this comment

jpisaac Nov 20, 2020

Choose a reason for hiding this comment

yanxinyi Nov 20, 2020

Choose a reason for hiding this comment

stoty commented Nov 21, 2020

stoty commented Nov 25, 2020

jpisaac left a comment

Choose a reason for hiding this comment

jpisaac Nov 25, 2020

Choose a reason for hiding this comment

stoty commented Nov 26, 2020

yanxinyi commented Nov 26, 2020

stoty commented Nov 26, 2020

stoty commented Dec 4, 2020

jpisaac left a comment

Choose a reason for hiding this comment