PHOENIX-5895: Leverage WALCellFilter in the SystemCatalogWALEntryFilter to replicate system catalog table

[sandeepvinayak]

No description provided.

[virajjasani]

+1 (non-binding) for 4.x backport, pending QA

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 12s	4.x passed
+1 💚	compile	0m 58s	4.x passed
+1 💚	checkstyle	0m 30s	4.x passed
+1 💚	javadoc	0m 43s	4.x passed
+0 🆗	spotbugs	2m 56s	phoenix-core in 4.x has 950 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 21s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
-1 ❌	checkstyle	0m 30s	phoenix-core: The patch generated 2 new + 9 unchanged - 8 fixed = 11 total (was 17)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 3s	the patch passed
		_ Other Tests _
-1 ❌	unit	135m 40s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		166m 28s

Reason	Tests
Failed junit tests	phoenix.end2end.AlterTableWithViewsIT
	phoenix.end2end.index.GlobalImmutableTxIndexIT
	phoenix.end2end.IndexToolForNonTxGlobalIndexIT
	phoenix.end2end.UpsertSelectIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-981/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#981
JIRA Issue	PHOENIX-5895
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux d88c550027f4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / e57fcc8
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-981/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-981/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-981/2/testReport/
Max. process+thread count	6332 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-981/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[gjacoby126]

+1

[gjacoby126]

@sandeepvinayak - the test failures look like environmental minicluster issues, but could you please rerun the failed tests locally to confirm that they pass?

[ChinmaySKulkarni]

@sandeepvinayak I think this is almost ready to be merged. Please just check the test failures and re-run those tests locally as Geoffrey advised.

[sandeepvinayak]

@ChinmaySKulkarni @gjacoby126 All the failing tests are good locally.