PHOENIX-6082 : Avoid checkAndPut when altering properties for a table or view with column-encoding enabled

[virajjasani]

4.x backport of PR #982

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 8s	4.x passed
+1 💚	compile	0m 56s	4.x passed
+1 💚	checkstyle	1m 40s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	2m 55s	phoenix-core in 4.x has 950 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 20s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
-1 ❌	checkstyle	1m 42s	phoenix-core: The patch generated 2 new + 2791 unchanged - 5 fixed = 2793 total (was 2796)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 42s	the patch passed
+1 💚	spotbugs	3m 3s	the patch passed
		_ Other Tests _
-1 ❌	unit	130m 9s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 39s	The patch does not generate ASF License warnings.
		163m 8s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#983
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 0dcc3bedb512 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / e57fcc8
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/2/testReport/
Max. process+thread count	6612 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[stoty]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 5s	4.x passed
+1 💚	compile	0m 53s	4.x passed
+1 💚	checkstyle	1m 40s	4.x passed
+1 💚	javadoc	0m 46s	4.x passed
+0 🆗	spotbugs	2m 54s	phoenix-core in 4.x has 950 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 21s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
-1 ❌	checkstyle	1m 41s	phoenix-core: The patch generated 2 new + 2791 unchanged - 5 fixed = 2793 total (was 2796)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
+1 💚	spotbugs	3m 2s	the patch passed
		_ Other Tests _
-1 ❌	unit	137m 14s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		170m 11s

Reason	Tests
Failed junit tests	phoenix.end2end.QueryIT
	phoenix.end2end.DropIndexedColsIT
	phoenix.end2end.index.GlobalMutableNonTxIndexIT
	phoenix.end2end.index.DropColumnIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#983
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux b4ebd698d985 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / 7ac4dff
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/4/testReport/
Max. process+thread count	6455 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-983/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[ChinmaySKulkarni]

+1, thanks! Waiting for any other reviews before committing your changes.
Btw, the test failures look unrelated and flaky but I think we should open a Jira to fix these tests/contact INFRA if it is an infra issue (OOM, shutdowns, etc.) WDYT @virajjasani @yanxinyi @gjacoby126 ?

[virajjasani]

Sure @ChinmaySKulkarni , sounds good. Let me try to collect some of these flaky tests results and create Jira accordingly.