Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6086 : Avoid restoring snapshots of System tables #997

Merged
merged 1 commit into from
Dec 2, 2020
Merged

PHOENIX-6086 : Avoid restoring snapshots of System tables #997

merged 1 commit into from
Dec 2, 2020

Conversation

virajjasani
Copy link
Contributor

@virajjasani virajjasani commented Dec 2, 2020

4.x backport of PR #996

@stoty
Copy link
Contributor

stoty commented Dec 2, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 10m 51s 4.x passed
+1 💚 compile 0m 54s 4.x passed
+1 💚 checkstyle 1m 25s 4.x passed
+1 💚 javadoc 0m 44s 4.x passed
+0 🆗 spotbugs 2m 52s phoenix-core in 4.x has 950 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 compile 0m 56s the patch passed
+1 💚 javac 0m 56s the patch passed
-1 ❌ checkstyle 1m 27s phoenix-core: The patch generated 2 new + 2165 unchanged - 10 fixed = 2167 total (was 2175)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 43s the patch passed
+1 💚 spotbugs 3m 9s the patch passed
_ Other Tests _
-1 ❌ unit 135m 40s phoenix-core in the patch failed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
174m 13s
Reason Tests
Failed junit tests phoenix.end2end.DeleteIT
phoenix.end2end.index.GlobalIndexOptimizationIT
phoenix.end2end.index.AlterIndexIT
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #997
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 055bba7ee7ad 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 0b69306
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/1/testReport/
Max. process+thread count 6733 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty
Copy link
Contributor

stoty commented Dec 2, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 11m 15s 4.x passed
+1 💚 compile 0m 56s 4.x passed
+1 💚 checkstyle 1m 26s 4.x passed
+1 💚 javadoc 0m 44s 4.x passed
+0 🆗 spotbugs 2m 49s phoenix-core in 4.x has 950 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 24s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
-1 ❌ checkstyle 1m 26s phoenix-core: The patch generated 5 new + 2162 unchanged - 13 fixed = 2167 total (was 2175)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 2m 58s the patch passed
_ Other Tests _
-1 ❌ unit 139m 38s phoenix-core in the patch failed.
+1 💚 asflicense 0m 37s The patch does not generate ASF License warnings.
172m 10s
Reason Tests
Failed junit tests phoenix.end2end.ViewIT
phoenix.end2end.RangeScanIT
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #997
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux 6e751084ce5f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 0b69306
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/2/testReport/
Max. process+thread count 6398 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-997/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni ChinmaySKulkarni merged commit b8cb658 into apache:4.x Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants