Add default session id

apache · Jul 20, 2022 · 59f3f1a · 59f3f1a
1 parent 3642e35
commit 59f3f1a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/...ion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java b/...ion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java
@@ -18,8 +18,10 @@
  */
 package org.apache.pinot.plugin.stream.kinesis;
 
+import com.google.common.base.Joiner;
 import com.google.common.base.Preconditions;
 import java.util.Map;
+import java.util.UUID;
 import org.apache.pinot.spi.stream.StreamConfig;
 import software.amazon.awssdk.services.kinesis.model.ShardIteratorType;
 
@@ -83,21 +85,18 @@ public KinesisConfig(StreamConfig streamConfig) {
     _iamRoleBasedAccess =
         Boolean.parseBoolean(props.getOrDefault(IAM_ROLE_BASED_ACCESS_ENABLED, DEFAULT_IAM_ROLE_BASED_ACCESS_ENABLED));
     _roleArn = props.get(ROLE_ARN);
-    _roleSessionName = props.get(ROLE_SESSION_NAME);
+    _roleSessionName =
+        props.getOrDefault(ROLE_SESSION_NAME, Joiner.on("-").join("pinot", "kinesis", UUID.randomUUID()));
     _externalId = props.get(EXTERNAL_ID);
     _sessionDurationSeconds =
         Integer.parseInt(props.getOrDefault(SESSION_DURATION_SECONDS, DEFAULT_SESSION_DURATION_SECONDS));
     _asyncSessionUpdateEnabled =
         Boolean.parseBoolean(props.getOrDefault(ASYNC_SESSION_UPDATED_ENABLED, DEFAULT_ASYNC_SESSION_UPDATED_ENABLED));
 
-
     if (_iamRoleBasedAccess) {
       Preconditions.checkNotNull(_roleArn,
           "Must provide 'roleArn' in stream config for table %s if iamRoleBasedAccess is enabled",
           streamConfig.getTableNameWithType());
-      Preconditions.checkNotNull(_roleSessionName,
-          "Must provide 'roleSessionName' in stream config for table %s if iamRoleBasedAccess is enabled",
-          streamConfig.getTableNameWithType());
     }
   }