Remove MaxDirectMemorySize settings

apache · Mar 8, 2020 · 791fcca · 791fcca
1 parent ce3b46e
commit 791fcca
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 11 deletions.
diff --git a/kubernetes/helm/README.md b/kubernetes/helm/README.md
@@ -343,7 +343,7 @@ following configurable parameters:
 | `server.persistence.size`                      | Size of data volume                                                                                                                                                        | `4G`                                                               |
 | `server.persistence.mountPath`                 | Mount path of server data volume                                                                                                                                           | `/var/pinot/server/data`                                           |
 | `server.persistence.storageClass`              | Storage class of backing PVC                                                                                                                                               | `""`                                                               |
-| `server.jvmOpts`                               | Pinot Server JVM Options                                                                                                                                                   | `-Xms4G -Xmx4G -XX:MaxDirectMemorySize=10g`                        |
+| `server.jvmOpts`                               | Pinot Server JVM Options                                                                                                                                                   | `-Xms4G -Xmx4G`                                                    |
 | `server.log4j2ConfFile`                        | Pinot Server log4j2 configuration file                                                                                                                                     | `/opt/pinot/conf/pinot-server-log4j2.xml`                          |
 | `server.pluginsDir`                            | Pinot Server plugins directory                                                                                                                                             | `/opt/pinot/plugins`                                               |
 | `server.service.port`                          | Service Port                                                                                                                                                               | `8098`                                                             |

diff --git a/kubernetes/helm/values.yaml b/kubernetes/helm/values.yaml
@@ -143,7 +143,7 @@ server:
     storageClass: ""
     #storageClass: "ssd"
 
-  jvmOpts: "-Xms4G -Xmx4G -XX:MaxDirectMemorySize=10g"
+  jvmOpts: "-Xms4G -Xmx4G"
 
   log4j2ConfFile: /opt/pinot/conf/pinot-server-log4j2.xml
   pluginsDir: /opt/pinot/plugins

diff --git a/pinot-integration-tests/pom.xml b/pinot-integration-tests/pom.xml
@@ -56,9 +56,6 @@
               <jvmSettings>
                 <initialMemorySize>4G</initialMemorySize>
                 <maxMemorySize>4G</maxMemorySize>
-                <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
-                </extraArguments>
               </jvmSettings>
             </program>
           </programs>

diff --git a/pinot-tools/pom.xml b/pinot-tools/pom.xml
@@ -154,7 +154,6 @@
                 <initialMemorySize>4G</initialMemorySize>
                 <maxMemorySize>4G</maxMemorySize>
                 <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/pinot-admin-log4j2.xml</extraArgument>
                 </extraArguments>
               </jvmSettings>
@@ -166,7 +165,6 @@
                 <initialMemorySize>1G</initialMemorySize>
                 <maxMemorySize>20G</maxMemorySize>
                 <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/pinot-tools-log4j2.xml</extraArgument>
                 </extraArguments>
               </jvmSettings>
@@ -178,7 +176,6 @@
                 <initialMemorySize>10G</initialMemorySize>
                 <maxMemorySize>30G</maxMemorySize>
                 <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/pinot-tools-log4j2.xml</extraArgument>
                 </extraArguments>
               </jvmSettings>
@@ -190,7 +187,6 @@
                 <initialMemorySize>10G</initialMemorySize>
                 <maxMemorySize>30G</maxMemorySize>
                 <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=30g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/pinot-tools-log4j2.xml</extraArgument>
                 </extraArguments>
               </jvmSettings>
@@ -268,7 +264,6 @@
                 <initialMemorySize>1G</initialMemorySize>
                 <maxMemorySize>1G</maxMemorySize>
                 <extraArguments>
-                  <extraArgument>-XX:MaxDirectMemorySize=6g</extraArgument>
                   <extraArgument>-Dlog4j2.configurationFile=conf/quickstart-log4j2.xml</extraArgument>
                 </extraArguments>
               </jvmSettings>

diff --git a/pom.xml b/pom.xml
@@ -132,7 +132,7 @@
     <log4j.version>2.11.2</log4j.version>
 
     <!-- Sets the VM argument line used when unit tests are run. -->
-    <argLine>-Xms4g -Xmx4g -XX:MaxPermSize=512m -XX:MaxDirectMemorySize=10g</argLine>
+    <argLine>-Xms4g -Xmx4g</argLine>
 
     <!-- handle kafka imports
     kafka dependency is still explicitly defined in pinot-integration-tests, pinot-tools and pinot-perf pom files.