Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade inconsistency: Confusing behaviour with noDictionaryConfig and fieldConfig for enabling compression on raw forward index. #11745

Closed
t0mpere opened this issue Oct 5, 2023 · 3 comments
Closed

Upgrade inconsistency: Confusing behaviour with noDictionaryConfig and fieldConfig for enabling compression on raw forward index. #11745

t0mpere opened this issue Oct 5, 2023 · 3 comments
Labels
bug

Comments

@t0mpere
Copy link
Contributor

t0mpere commented Oct 5, 2023

Up to version 0.12.1 noDictionaryConfig was usable to enable compression for raw forward indexes on metrics column. Now in 1.0 this is only doable by fieldConfig. Is there a plan to deprecate noDictionaryConfig? This might be an issue upgrading since BYTES column without compression tend to blow up in size due to the raw forward index.
@Jackie-Jiang
Copy link
Contributor

@gortiz Can you take a look? I feel it might be a bug in the index-spi

gortiz added a commit to gortiz/pinot that referenced this issue Oct 11, 2023
@gortiz
Fix regression in ForwardIndexType detected in apache#11745
08f0419
@gortiz gortiz mentioned this issue Oct 11, 2023
Merged
@gortiz
Copy link
Contributor

gortiz commented Oct 11, 2023

Sorry for the delay. I was able to reproduce the issue. It should be fixed in #11784, which also adds some tests to verify the correct behavior

Jackie-Jiang pushed a commit that referenced this issue Oct 14, 2023
@gortiz
Fix regression in ForwardIndexType detected in #11745 (#11784)
d7d504b
@Jackie-Jiang
Copy link
Contributor

Fixed with #11784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gortiz @Jackie-Jiang @t0mpere