Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute file paths for compat testing #6787

Closed
mcvsubbu opened this issue Apr 13, 2021 · 0 comments
Closed

Use absolute file paths for compat testing #6787

mcvsubbu opened this issue Apr 13, 2021 · 0 comments

Comments

@mcvsubbu
Copy link
Contributor

mcvsubbu commented Apr 13, 2021

Compatibility tester needs that the yaml files used for testing (and the file paths within yaml files) reside in the resource directory path. We should change these so that the files can be absolute path. This will allow Pinot installations to specify their own test suite and run compat testing before upgrade to new pinot versions.

The tester script should take a directory name (absolute path) as the argument where all the yaml files are located. The yaml files should be named as pre-controller-upgrade.yaml, pre-broker-upgrade.yaml, etc (6 of them) . The shell script should be modified to pick up these yaml files from the directory specified.

In addition, the directory should contain a subdir called config under which all the config file names should reside (e.g. the table config files, schema files, kafka producer config files. etc.), possibly under subdirectories if the user chooses to put them that way. These config files are the ones referenced inside the yaml files.

So ,if a yaml file referes to a table config file as mytables/table1.conf, then we should look in the directory ${TOPLEVELDIR}/config/mytables/table1.conf in order to retrieve the table config file.

GSharayu added a commit to GSharayu/pinot that referenced this issue May 12, 2021
harold-kfuse pushed a commit to harold-kfuse/incubator-pinot that referenced this issue May 14, 2021
GSharayu added a commit to GSharayu/pinot that referenced this issue May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant