Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine "GET /segments" API & "GET /segments/{tableName}/select" #10412

Merged
merged 1 commit into from Apr 4, 2023
Merged

Combine "GET /segments" API & "GET /segments/{tableName}/select" #10412

merged 1 commit into from Apr 4, 2023

Conversation

snleee
Copy link
Contributor

@snleee snleee commented Mar 12, 2023

  • Add the time filter for "GET /segments" API
  • Add deprecated annotation for "GET /segments/{tableName}/select"

@snleee snleee force-pushed the add-timefilter-segments-api branch 5 times, most recently from 9124026 to 0812575 Compare March 12, 2023 08:55
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2023 •
edited

Codecov Report

Merging #10412 (b468e7d) into master (d475712) will increase coverage by 3.78%.
The diff coverage is 25.58%.

@@             Coverage Diff              @@
##             master   #10412      +/-   ##
============================================
+ Coverage     64.25%   68.03%   +3.78%     
- Complexity     6059     6109      +50     
============================================
  Files          1997     2092      +95     
  Lines        108768   112732    +3964     
  Branches      16620    17147     +527     
============================================
+ Hits          69888    76697    +6809     
+ Misses        33816    30512    -3304     
- Partials       5064     5523     +459
Flag Coverage Δ
integration1 24.52% <25.58%> (?)
unittests1 67.54% <0.00%> (-0.47%) ⬇️
unittests2 13.89% <20.93%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...spi/utils/builder/ControllerRequestURLBuilder.java 0.00% <0.00%> (ø)
...ler/api/resources/PinotSegmentRestletResource.java 30.45% <25.00%> (+20.48%) ⬆️
...ntroller/helix/core/PinotHelixResourceManager.java 69.14% <75.00%> (+6.54%) ⬆️
...e/pinot/common/utils/FileUploadDownloadClient.java 58.36% <100.00%> (+44.08%) ⬆️
...ot/plugin/minion/tasks/SegmentConversionUtils.java 76.71% <100.00%> (+62.82%) ⬆️

... and 554 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

jackjlli
jackjlli approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but LGTM.

pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/ControllerRequestURLBuilder.java Outdated Show resolved Hide resolved
jtao15
jtao15 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@jtao15 jtao15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise

...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java Outdated Show resolved Hide resolved
@snleee snleee force-pushed the add-timefilter-segments-api branch from 0812575 to 6c24293 Compare March 31, 2023 05:09
@snleee
Combine "GET /segments" API & "GET /segments/{tableName}/select"
b468e7d 
- Add the time filter for "GET /segments" API
- Add deprecated annotation for "GET /segments/{tableName}/select"
@snleee snleee force-pushed the add-timefilter-segments-api branch from 6c24293 to b468e7d Compare March 31, 2023 05:25
@snleee snleee merged commit acaf201 into apache:master Apr 4, 2023
14 checks passed
@snleee snleee deleted the add-timefilter-segments-api branch April 4, 2023 05:57
abhioncbr pushed a commit to abhioncbr/pinot that referenced this pull request Apr 14, 2023
@snleee @abhioncbr
Combine "GET /segments" API & "GET /segments/{tableName}/select" (apa…
2799c85 
…che#10412)

- Add the time filter for "GET /segments" API
- Add deprecated annotation for "GET /segments/{tableName}/select"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhtaoxiang zhtaoxiang zhtaoxiang left review comments

@jackjlli jackjlli jackjlli approved these changes

@jtao15 jtao15 jtao15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@snleee @codecov-commenter @zhtaoxiang @jackjlli @jtao15