Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null handling in streaming selection operator #10453

Merged

Conversation

cbalci
Copy link
Contributor

@cbalci cbalci commented Mar 21, 2023

Null handling support was not added to the StreamingSelectionOnlyOperator. This is causing default values being returned for streaming/gRPC queries, even if the query option enableNullHandling=true is set.
This change fixes it.

Testing

  • Added unit test coverage
  • Ran manual tests to confirm gRPC endpoint returns null for null columns, rather than defaults.

bugfix

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #10453 (c465623) into master (cb1069f) will increase coverage by 0.07%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##             master   #10453      +/-   ##
============================================
+ Coverage     70.24%   70.32%   +0.07%     
+ Complexity     6110     6108       -2     
============================================
  Files          2061     2061              
  Lines        111752   111763      +11     
  Branches      16985    16991       +6     
============================================
+ Hits          78504    78595      +91     
+ Misses        27720    27638      -82     
- Partials       5528     5530       +2     
Flag Coverage Δ
integration1 24.53% <0.00%> (+0.14%) ⬆️
integration2 24.23% <23.07%> (+<0.01%) ⬆️
unittests1 67.99% <61.53%> (+0.03%) ⬆️
unittests2 13.91% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ator/streaming/StreamingSelectionOnlyOperator.java 86.27% <76.92%> (-3.73%) ⬇️

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jackie-Jiang Jackie-Jiang merged commit 549d565 into apache:master Mar 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants