wait for full segment commit protocol on force commit #10479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10479 +/- ##
============================================
+ Coverage 70.26% 70.27% +0.01%
+ Complexity 6113 5274 -839
============================================
Files 2070 2070
Lines 111951 111950 -1
Branches 17051 17050 -1
============================================
+ Hits 78658 78672 +14
+ Misses 27746 27729 -17
- Partials 5547 5549 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Jackie-Jiang , do you mind rerunning the failed workflows? looks like a flake |
sajjad-moradi
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #10460
This isn't necessarily a bug, but it can lead to unexpected behavior. We observed that picking the first server to respond to force commit led to a case where a server that was several hours behind was chosen as the winner. In the issue, we discussed that the intention was to kick off committing immediately on force commit, but it should generally not be detrimental (extra ~3 seconds) to wait for the typical segment commit protocol.