Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove v0_deprecated batch ingestion jobs #10532

Merged
merged 1 commit into from Apr 4, 2023

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Apr 3, 2023

Clean up v0_deprecated batch ingestion jobs

@xiangfu0 xiangfu0 changed the title Clean up v0_deprecated batch ingestion jobs [cleanup] Remove v0_deprecated batch ingestion jobs Apr 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #10532 (7f36b2e) into master (1fc8150) will increase coverage by 42.57%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #10532       +/-   ##
=============================================
+ Coverage     27.80%   70.37%   +42.57%     
- Complexity       58     6467     +6409     
=============================================
  Files          2087     2103       +16     
  Lines        112307   112739      +432     
  Branches      16918    16973       +55     
=============================================
+ Hits          31226    79342    +48116     
+ Misses        77988    27850    -50138     
- Partials       3093     5547     +2454     
Flag Coverage Δ
integration1 24.48% <ø> (+0.13%) ⬆️
integration2 24.33% <ø> (+0.12%) ⬆️
unittests1 67.88% <ø> (?)
unittests2 13.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1482 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang
Copy link
Contributor

@snleee @jackjlli Do we still need these old deprecated ingestion jobs?

Copy link
Contributor

@jackjlli jackjlli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinkedIn no longer depends on v0_deprecated. LGTM.

@xiangfu0 xiangfu0 merged commit 145a8c0 into apache:master Apr 4, 2023
16 checks passed
@xiangfu0 xiangfu0 deleted the cleanup-batch-ingestion-v0 branch April 4, 2023 18:36
abhioncbr pushed a commit to abhioncbr/pinot that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants