[multistage] populate queryOption down to leaf #10626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10626 +/- ##
============================================
+ Coverage 27.66% 34.97% +7.31%
- Complexity 58 462 +404
============================================
Files 2090 2106 +16
Lines 112578 113016 +438
Branches 16972 17028 +56
============================================
+ Hits 31145 39532 +8387
+ Misses 78333 70052 -8281
- Partials 3100 3432 +332
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 310 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Apr 17, 2023
xiangfu0
reviewed
Apr 17, 2023
| @@ -126,8 +126,7 @@ public static ServerPlanRequestContext build(MailboxService<TransferableBlock> m | |||
| QUERY_OPTIMIZER.optimize(pinotQuery, tableConfig, schema); | |||
|
|
|||
| // 2. set pinot query options according to requestMetadataMap | |||
| pinotQuery.setQueryOptions( | |||
| ImmutableMap.of(CommonConstants.Broker.Request.QueryOptionKey.TIMEOUT_MS, String.valueOf(timeoutMs))); | |||
| updateQueryOptions(pinotQuery, requestMetadataMap, timeoutMs, traceEnabled); | |||
There was a problem hiding this comment.
do we want to support stage based query options as well?
There was a problem hiding this comment.
stage-based query options are also added. they are merged into requestMetadataMap during dispatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required by #10423