Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server metrics to capture gRPC activity #10678

Merged
merged 1 commit into from Apr 25, 2023

Conversation

cbalci
Copy link
Contributor

@cbalci cbalci commented Apr 24, 2023

Can be used to:

  • distinguish gRPC queries from Netty based ones
  • track migrations from HTTP to gRPC
  • etc.

observability

@codecov-commenter
Copy link

Codecov Report

Merging #10678 (7450776) into master (866c796) will decrease coverage by 56.42%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10678       +/-   ##
=============================================
- Coverage     70.25%   13.83%   -56.42%     
+ Complexity     6503      439     -6064     
=============================================
  Files          2108     2054       -54     
  Lines        113866   111423     -2443     
  Branches      17181    16895      -286     
=============================================
- Hits          79991    15411    -64580     
- Misses        28283    94754    +66471     
+ Partials       5592     1258     -4334     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 13.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pinot/common/metrics/ServerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...che/pinot/core/transport/grpc/GrpcQueryServer.java 0.00% <0.00%> (-52.57%) ⬇️

... and 1661 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit d806b5f into apache:master Apr 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants