Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexOutOfBoundException in filtered aggregation group-by #11231

Merged
merged 1 commit into from Aug 1, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

Currently it can throw IndexOutOfBoundException when there are more group-by expressions than filters.
Added a test to catch that

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Merging #11231 (124ceab) into master (e809b4e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #11231   +/-   ##
=======================================
  Coverage    0.11%    0.11%           
=======================================
  Files        2229     2229           
  Lines      119768   119769    +1     
  Branches    18126    18126           
=======================================
  Hits          137      137           
- Misses     119611   119612    +1     
  Partials       20       20           
Flag Coverage Δ
integration1temurin11 0.00% <0.00%> (ø)
integration1temurin17 0.00% <0.00%> (ø)
integration1temurin20 0.00% <0.00%> (ø)
integration2temurin11 0.00% <0.00%> (ø)
integration2temurin20 0.00% <0.00%> (ø)
unittests1temurin11 0.00% <0.00%> (ø)
unittests1temurin17 ?
unittests1temurin20 0.00% <0.00%> (ø)
unittests2temurin11 0.11% <0.00%> (ø)
unittests2temurin17 0.11% <0.00%> (ø)
unittests2temurin20 0.11% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...t/core/operator/query/FilteredGroupByOperator.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit d359b72 into apache:master Aug 1, 2023
20 of 22 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_filtered_group_by branch August 1, 2023 03:29
s0nskar pushed a commit to s0nskar/pinot that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants