New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding query function override for Aggregate functions of multi valued column #11307
Adding query function override for Aggregate functions of multi valued column #11307
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11307 +/- ##
============================================
+ Coverage 63.04% 63.06% +0.01%
+ Complexity 1121 1120 -1
============================================
Files 2343 2343
Lines 125705 125743 +38
Branches 19309 19318 +9
============================================
+ Hits 79252 79294 +42
+ Misses 40808 40802 -6
- Partials 5645 5647 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Other than distinct count, other aggregation function also have the MV variance. Let's handle all of them here since the logic is the same.
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
I currently added for
Other possible Aggregations are : But was a bit concerned about overriding for |
@eaugene If user explicitly use |
a08b140
to
e7c5747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
Outdated
Show resolved
Hide resolved
9e3d6be
to
1ebed95
Compare
Thanks @Jackie-Jiang for the review. Addressed the final set of comments & included override for the new distinctCountHLLplus aggregations introduced as a part of #11346 |
Adding query function override for distinct functions of multi valued column .
DISTINCTCOUNT
& Other distinct aggregate functions have a different behaviour when queried over a multivalued column with Dict enabled & disabled. This PR fixes that by overriding the function names to use multivalued Aggragation functions.Fixes : #11292