Add DECIMAL data type to orc record reader #11377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11377 +/- ##
============================================
- Coverage 61.52% 61.43% -0.09%
Complexity 6513 6513
============================================
Files 2233 2233
Lines 120083 120150 +67
Branches 18223 18235 +12
============================================
- Hits 73878 73813 -65
- Misses 40798 40920 +122
- Partials 5407 5417 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 41 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Aug 17, 2023
snleee
approved these changes
Aug 18, 2023
saurabhd336
pushed a commit
to saurabhd336/pinot
that referenced
this pull request
Aug 23, 2023
* Add DECIMAL data type to orc record reader * Add test --------- Co-authored-by: Kartik Khare <kharekartik@Kartiks-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already supported in AVRO so should be supported in other record readers as well.
The output is a String to preserve the long precision values.