Fail reload if derived columns can't be created #11559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11559 +/- ##
============================================
+ Coverage 63.03% 63.07% +0.03%
- Complexity 1108 1109 +1
============================================
Files 2320 2325 +5
Lines 124528 124787 +259
Branches 19011 19056 +45
============================================
+ Hits 78496 78706 +210
- Misses 40437 40480 +43
- Partials 5595 5601 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 45 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangfu0
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a reload operation silently fails without errors when a newly added derived column can't be created due to transform function failures. This change makes sure we always fail a reload op with an error if newly added derived columns can't be created. If for whatever reason this behaviour is desirable for certain reload ops, we may add a new option (like forceDownload) to the reload API to toggle.