Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: add toggle to hide/show query exceptions #11611

Merged
merged 2 commits into from Sep 18, 2023

Conversation

jayeshchoudhary
Copy link
Contributor

@jayeshchoudhary jayeshchoudhary commented Sep 18, 2023

This is UI, enhancement

What does this PR do?

  • Add a toggle to show/hide query exceptions in the UI
  • By Default, the exceptions will be collapsed and can be viewed by toggling show exception switch.

Screenshots

  • When there is only result or only exceptions
exceptions.mp4
  • when there are both exceptions and result
exception.partial.mp4

@Jackie-Jiang Jackie-Jiang added user-experience Related to user experience ui UI related issue labels Sep 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #11611 (612b73b) into master (49196ec) will increase coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11611      +/-   ##
============================================
+ Coverage     63.15%   63.20%   +0.05%     
- Complexity      207     1104     +897     
============================================
  Files          2324     2324              
  Lines        124534   124534              
  Branches      18994    18994              
============================================
+ Hits          78645    78710      +65     
+ Misses        40302    40237      -65     
  Partials       5587     5587              
Flag Coverage Δ
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.15% <ø> (+13.03%) ⬆️
java-17 63.02% <ø> (+<0.01%) ⬆️
java-20 63.03% <ø> (+0.01%) ⬆️
temurin 63.20% <ø> (+0.05%) ⬆️
unittests 63.19% <ø> (+0.05%) ⬆️
unittests1 67.47% <ø> (+0.02%) ⬆️
unittests2 14.55% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 merged commit 949083d into apache:master Sep 18, 2023
21 checks passed
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do i need to do something to enable this? i compiled with latest pinot-controller module and it is still showing plain exception without the toggle

@jayeshchoudhary
Copy link
Contributor Author

do i need to do something to enable this? i compiled with latest pinot-controller module and it is still showing plain exception without the toggle

It should work, can you rebase the latest master and check again, with all the components to the latest.

@walterddr
Copy link
Contributor

do i need to do something to enable this? i compiled with latest pinot-controller module and it is still showing plain exception without the toggle

It should work, can you rebase the latest master and check again, with all the components to the latest.

yes i did. i checked out and recompile from scratch. let me try it again after docker image release and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui UI related issue user-experience Related to user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants