Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LLRealtimeSegmentDataManager to RealtimeSegmentDataManager #11687

Merged
merged 1 commit into from Sep 27, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

Follow up on #11680

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #11687 (3c5645a) into master (ff264a3) will increase coverage by 48.48%.
Report is 2 commits behind head on master.
The diff coverage is 21.05%.

@@              Coverage Diff              @@
##             master   #11687       +/-   ##
=============================================
+ Coverage     14.45%   62.94%   +48.48%     
- Complexity      201     1118      +917     
=============================================
  Files          2341     2343        +2     
  Lines        125632   125672       +40     
  Branches      19313    19314        +1     
=============================================
+ Hits          18158    79100    +60942     
+ Misses       105935    40909    -65026     
- Partials       1539     5663     +4124     
Flag Coverage Δ
integration 0.00% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 14.44% <10.52%> (+14.44%) ⬆️
java-17 62.91% <21.05%> (+48.46%) ⬆️
java-20 14.46% <10.52%> (+0.02%) ⬆️
temurin 62.94% <21.05%> (+48.48%) ⬆️
unittests 62.94% <21.05%> (+48.48%) ⬆️
unittests1 67.03% <33.33%> (?)
unittests2 14.46% <10.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/manager/realtime/RealtimeSegmentDataManager.java 50.66% <100.00%> (ø)
...e/data/manager/realtime/SplitSegmentCommitter.java 24.24% <ø> (+24.24%) ⬆️
.../helix/FreshnessBasedConsumptionStatusChecker.java 100.00% <ø> (ø)
.../helix/IngestionBasedConsumptionStatusChecker.java 100.00% <100.00%> (ø)
...ter/helix/OffsetBasedConsumptionStatusChecker.java 91.66% <ø> (ø)
...ache/pinot/server/api/resources/DebugResource.java 0.00% <0.00%> (ø)
...r/helix/SegmentOnlineOfflineStateModelFactory.java 0.00% <0.00%> (ø)
...che/pinot/server/api/resources/TablesResource.java 60.98% <0.00%> (ø)
...ata/manager/realtime/RealtimeTableDataManager.java 32.00% <0.00%> (+32.00%) ⬆️
...server/starter/helix/HelixInstanceDataManager.java 0.00% <0.00%> (ø)

... and 1515 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit 44b803a into apache:master Sep 27, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the rename_ll_segment_manager branch September 27, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants