Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move jobId out of rebalanceConfig as it's more like a runtime context #11790

Merged
merged 2 commits into from Oct 12, 2023

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Oct 11, 2023

Move jobId out of rebalanceConfig as it's more like a runtime context. And as in the table rebalance restful API, jobId is not provided by caller but auto-gen'ed and returned to caller.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #11790 (70aa6e0) into master (884dbdb) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##             master   #11790    +/-   ##
==========================================
  Coverage     63.12%   63.13%            
- Complexity     1118     1140    +22     
==========================================
  Files          2342     2343     +1     
  Lines        125996   126305   +309     
  Branches      19378    19419    +41     
==========================================
+ Hits          79541    79742   +201     
- Misses        40791    40890    +99     
- Partials       5664     5673     +9     
Flag Coverage Δ
integration <0.01% <0.00%> (-0.01%) ⬇️
integration1 <0.01% <0.00%> (-0.01%) ⬇️
integration2 0.00% <0.00%> (ø)
java-11 63.08% <61.53%> (+0.02%) ⬆️
java-17 63.00% <61.53%> (+48.55%) ⬆️
java-20 62.97% <61.53%> (-0.03%) ⬇️
temurin 63.13% <61.53%> (+<0.01%) ⬆️
unittests 63.12% <61.53%> (+<0.01%) ⬆️
unittests1 67.25% <ø> (-0.01%) ⬇️
unittests2 14.43% <61.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ntroller/helix/core/PinotHelixResourceManager.java 63.45% <100.00%> (-0.03%) ⬇️
...ntroller/helix/core/rebalance/RebalanceConfig.java 100.00% <ø> (ø)
...ntroller/helix/core/rebalance/TableRebalancer.java 68.52% <ø> (-0.07%) ⬇️
...core/rebalance/tenant/DefaultTenantRebalancer.java 61.60% <83.33%> (+0.20%) ⬆️
...oller/api/resources/PinotTableRestletResource.java 45.74% <50.00%> (ø)
...roller/helix/core/relocation/SegmentRelocator.java 52.34% <0.00%> (ø)

... and 56 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@klsince klsince merged commit 0174c71 into apache:master Oct 12, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants