Add UltraLogLog support #11835
Merged
Add UltraLogLog support #11835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UltraLogLog is a variant of HyperLogLog from dynatrace, with an implementation available in hash4j under the apache license. This adds support for using it in the ways you'd use HLL in Pinot. When using it against normal java types, wyhash 4 is used as the default hashing algorithm, when bringing your own serialized sketches you can use any. * supports `UltraLogLog` as a data type * the serialization format includes serializing the P value as the first byte in the data stream, so the width is known in streams * adds `DistinctCountULL` and `DistinctCountRawULL` for use in SQL * raw outputs Base64 encoded bytes that can be fed into `UltraLogLog.wrap` in other services * adds startree support * adds merge rollup support * new transformaction functions added * `toULL` allows turning data into a ULL * `fromULL` lets you import ULLs encoded as byte arrays outside pinot
Codecov Report
@@ Coverage Diff @@
## master #11835 +/- ##
============================================
- Coverage 62.87% 62.80% -0.07%
+ Complexity 1141 1140 -1
============================================
Files 2367 2373 +6
Lines 127888 128207 +319
Branches 19732 19787 +55
============================================
+ Hits 80414 80525 +111
- Misses 41752 41958 +206
- Partials 5722 5724 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can you rebase to latest? |
done, updated |
xiangfu0
added
feature
release-notes
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UltraLogLog is a variant of HyperLogLog from dynatrace, with an implementation available in hash4j under the apache license.
This adds support for using it in the ways you'd use HLL in Pinot.
When using it against normal java types, wyhash 4 is used as the default hashing algorithm, when bringing your own serialized sketches you can use any.
UltraLogLogas a data typeDistinctCountULLandDistinctCountRawULLfor use in SQLUltraLogLog.wrapin other servicestoULLallows turning data into a ULLfromULLlets you import ULLs encoded as byte arrays outside pinotRelease Notes
distinctCountULLanddistinctCountRawULL)