Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPE for rebalance retry #11883

Merged
merged 1 commit into from Oct 26, 2023

Conversation

Jackie-Jiang
Copy link
Contributor

Currently it will log a NPE for each table without previous rebalance job

Copy link
Contributor

@klsince klsince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2023

Codecov Report

Merging #11883 (fdb68b2) into master (c3f7b6d) will decrease coverage by 26.53%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11883       +/-   ##
=============================================
- Coverage     61.35%   34.83%   -26.53%     
+ Complexity     1146      946      -200     
=============================================
  Files          2373     2297       -76     
  Lines        128276   124539     -3737     
  Branches      19803    19246      -557     
=============================================
- Hits          78706    43383    -35323     
- Misses        43872    78132    +34260     
+ Partials       5698     3024     -2674     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 46.60% <ø> (+0.01%) ⬆️
java-21 34.71% <0.00%> (+7.13%) ⬆️
skip-bytebuffers-false 34.82% <0.00%> (-26.54%) ⬇️
skip-bytebuffers-true 34.69% <0.00%> (+34.69%) ⬆️
temurin 34.83% <0.00%> (-26.53%) ⬇️
unittests 46.64% <ø> (-14.71%) ⬇️
unittests1 46.64% <ø> (+0.05%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...troller/helix/core/rebalance/RebalanceChecker.java 0.00% <0.00%> (-72.58%) ⬇️

... and 839 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit d6f22ac into apache:master Oct 26, 2023
19 checks passed
@Jackie-Jiang Jackie-Jiang deleted the fix_npe_retry_rebalance branch October 26, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants