Ask server to directly return final result for queries hitting single server #11938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11938 +/- ##
============================================
- Coverage 61.42% 61.40% -0.03%
+ Complexity 1147 1141 -6
============================================
Files 2378 2378
Lines 128894 128924 +30
Branches 19929 19939 +10
============================================
- Hits 79177 79165 -12
- Misses 44001 44041 +40
- Partials 5716 5718 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Jackie-Jiang
force-pushed
the
auto_apply_return_final_response
branch
from
e4fa9bf
to
8012442
Compare
walterddr
reviewed
Nov 3, 2023
| // Set the query option to directly return final result for single server query unless it is explicitly disabled | ||
| if (numServers == 1) { | ||
| if (queryOptions.putIfAbsent(QueryOptionKey.SERVER_RETURN_FINAL_RESULT, "true") == null | ||
| && offlineBrokerRequest != serverBrokerRequest) { |
There was a problem hiding this comment.
Good catch! Let me also add some comment explaining this
Jackie-Jiang
force-pushed
the
auto_apply_return_final_response
branch
from
8012442
to
542128d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9304 introduced the query option
serverReturnFinalResultwhich can be used when no broker reduce is required, and ask server to directly return the final aggregation result.This PR extends that by automatically applying this query option when only one server is queried.
This PR also contains some bug fixes: