Support constant filter in QueryContext, and make server able to handle it #11956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
added
enhancement
multi-stage
Codecov Report
@@ Coverage Diff @@
## master #11956 +/- ##
============================================
- Coverage 61.45% 61.40% -0.05%
+ Complexity 1145 207 -938
============================================
Files 2385 2385
Lines 129065 129137 +72
Branches 19955 19991 +36
============================================
- Hits 79317 79301 -16
- Misses 44023 44083 +60
- Partials 5725 5753 +28
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 37 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
walterddr
approved these changes
Nov 7, 2023
| @@ -658,7 +658,7 @@ public void testFilteredAggregations() { | |||
| } | |||
|
|
|||
| @Test | |||
| void testDeduplicateOrderByExpressions() { | |||
| public void testDeduplicateOrderByExpressions() { | |||
| case LITERAL: | ||
| // TODO: Handle literals. | ||
| throw new IllegalStateException(); | ||
| return FilterContext.forConstant(new LiteralContext(thriftExpression.getLiteral()).getBooleanValue()); |
There was a problem hiding this comment.
general question: why do we need to repeat ourselves on these utils one for thrift and one for function context?
it looks like the only difference is one is for WHERE and one is for HAVING?
There was a problem hiding this comment.
One is used in aggregation FILTER where the expression is already parsed into context format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we rely on broker to remove the constant (true/false) filter, and server doesn't support processing constant filter. This PR adds the server side support to handle constant filter which is needed for multi-stage engine as leaf stage