Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][multistage] enhance query plan test #11966

Merged
merged 1 commit into from Nov 8, 2023

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 8, 2023

  • optimized query physical plan to omit all mailbox
    • non-leaf will also get omit
    • multiple worker within a server will also get omit
    • all places with contextual info are now
      • printed as the following format: <PREFIX>[<FRAGMENT_ID>]@<HOSTNAME>:<PORT>|[<WORKER_ID>],
      • with multiple instances of the context, the format will be wrapped in { and } in a comma-separated list.
...
              └── [1]@localhost:1|[1] PROJECT
                  └── [1]@localhost:1|[1] JOIN
                      ├── [1]@localhost:1|[1] MAIL_RECEIVE(HASH_DISTRIBUTED)
                      │   ├── [2]@localhost:2|[2] MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:2|[2, 3],[1]@localhost:1|[0, 1]} (Subtree Omitted)
                      │   ├── [2]@localhost:2|[3] MAIL_SEND(HASH_DISTRIBUTED)->{[1]@localhost:2|[2, 3],[1]@localhost:1|[0, 1]} (Subtree Omitted)
...
  • support other plan parsing in ResourceBasedQueryPlansTest
    • regex replace supported feature such as AS ..., ...ATTRIBUTES
    • WITH ... is not supported as we don't actually have corresponding processing on this variance yet.

This also addresses the verbose issue of subtree omit in #11272

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #11966 (bd038c3) into master (45f1869) will decrease coverage by 0.15%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #11966      +/-   ##
============================================
- Coverage     61.43%   61.29%   -0.15%     
- Complexity     1135     1141       +6     
============================================
  Files          2385     2385              
  Lines        129150   129149       -1     
  Branches      19994    19994              
============================================
- Hits          79347    79164     -183     
- Misses        44049    44237     +188     
+ Partials       5754     5748       -6     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 27.60% <0.00%> (-33.78%) ⬇️
java-21 61.29% <100.00%> (-0.02%) ⬇️
skip-bytebuffers-false 61.27% <100.00%> (-0.14%) ⬇️
skip-bytebuffers-true 61.26% <100.00%> (-0.03%) ⬇️
temurin 61.29% <100.00%> (-0.15%) ⬇️
unittests 61.29% <100.00%> (-0.15%) ⬇️
unittests1 46.50% <100.00%> (-0.17%) ⬇️
unittests2 27.59% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...inot/query/planner/PhysicalExplainPlanVisitor.java 88.29% <100.00%> (+0.79%) ⬆️

... and 26 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@walterddr walterddr merged commit b5e9823 into apache:master Nov 8, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants