Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fromULL scalar function #11995

Merged
merged 1 commit into from Nov 14, 2023

Conversation

andimiller
Copy link
Contributor

Annotation was missing to allow this to be called

Annotation was missing to allow this to be called
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #11995 (3d6148d) into master (b38bd9f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #11995      +/-   ##
============================================
- Coverage     61.63%   61.62%   -0.02%     
  Complexity      207      207              
============================================
  Files          2385     2385              
  Lines        129214   129214              
  Branches      20003    20003              
============================================
- Hits          79640    79622      -18     
- Misses        43773    43791      +18     
  Partials       5801     5801              
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 ?
java-11 61.57% <ø> (+26.56%) ⬆️
java-21 61.49% <ø> (-0.03%) ⬇️
skip-bytebuffers-false 61.62% <ø> (+0.02%) ⬆️
skip-bytebuffers-true <0.01% <ø> (-61.50%) ⬇️
temurin 61.62% <ø> (-0.02%) ⬇️
unittests 61.61% <ø> (-0.02%) ⬇️
unittests1 46.95% <ø> (+<0.01%) ⬆️
unittests2 27.58% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...he/pinot/core/function/scalar/SketchFunctions.java 59.33% <ø> (ø)

... and 17 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@Jackie-Jiang Jackie-Jiang merged commit 5f22d16 into apache:master Nov 14, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants