Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage][bugfix] fix multi-semi-join issues #12038

Merged
merged 3 commits into from Nov 22, 2023

Conversation

walterddr
Copy link
Contributor

@walterddr walterddr commented Nov 22, 2023

this fixes #12014..

side effects (good ones)

  • alter the order of AGG_PROJECT merge mechanism, now projects are much more concise
  • avoided exchange more than required data off leaf.
  • fix another bug when dynamic broadcast was applying to lateral semi-join --> it is not allowed.

@walterddr walterddr added bugfix multi-stage Related to the multi-stage query engine labels Nov 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32db500) 61.62% compared to head (288e386) 61.61%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12038      +/-   ##
============================================
- Coverage     61.62%   61.61%   -0.01%     
+ Complexity     1151     1147       -4     
============================================
  Files          2385     2385              
  Lines        129423   129519      +96     
  Branches      20036    20043       +7     
============================================
+ Hits          79751    79802      +51     
- Misses        43855    43907      +52     
+ Partials       5817     5810       -7     
Flag Coverage Δ
custom-integration1 <0.01% <ø> (ø)
integration <0.01% <ø> (ø)
integration1 <0.01% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 61.57% <ø> (-0.01%) ⬇️
java-21 61.49% <ø> (-0.01%) ⬇️
skip-bytebuffers-false 61.60% <ø> (+<0.01%) ⬆️
skip-bytebuffers-true 61.45% <ø> (-0.03%) ⬇️
temurin 61.61% <ø> (-0.01%) ⬇️
unittests 61.60% <ø> (-0.01%) ⬇️
unittests1 46.96% <ø> (+<0.01%) ⬆️
unittests2 27.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@walterddr walterddr merged commit 22403e5 into apache:master Nov 22, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[multistage][bug] nested multi semi-join not applied
3 participants