Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need for segment locks during segment preloading #12077

Merged

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Nov 30, 2023

Taking segmentLock during segment preloading is not needed and in fact could cause deadlock when other tables trying to take the same segmentLock due to hash collision

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c57117a) 0.00% compared to head (4342914) 61.63%.
Report is 3 commits behind head on master.

Files Patch % Lines
...cal/upsert/BasePartitionUpsertMetadataManager.java 50.00% 3 Missing and 2 partials ⚠️
...t/local/upsert/BaseTableUpsertMetadataManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12077       +/-   ##
=============================================
+ Coverage      0.00%   61.63%   +61.62%     
- Complexity        6     1153     +1147     
=============================================
  Files          2314     2389       +75     
  Lines        126078   129817     +3739     
  Branches      19524    20082      +558     
=============================================
+ Hits              6    80010    +80004     
+ Misses       126072    43978    -82094     
- Partials          0     5829     +5829     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (?)
integration2 0.00% <0.00%> (?)
java-11 61.56% <45.45%> (+61.56%) ⬆️
java-21 61.51% <45.45%> (+61.50%) ⬆️
skip-bytebuffers-false 61.61% <45.45%> (?)
skip-bytebuffers-true 61.48% <45.45%> (?)
temurin 61.63% <45.45%> (+61.62%) ⬆️
unittests 61.62% <45.45%> (?)
unittests1 46.90% <0.00%> (?)
unittests2 27.61% <45.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@klsince klsince merged commit d7c76b9 into apache:master Nov 30, 2023
19 checks passed
@klsince klsince deleted the fix_potential_deadlock_preloading_segments branch November 30, 2023 22:16
saurabhd336 pushed a commit to saurabhd336/pinot that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants