[multistage][bugfix] improve sort copy rule #12237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logical sort should not be copied when there's no fetch or fetch limit is too large
2 tasks
walterddr
commented
Jan 8, 2024
| @@ -42,6 +42,7 @@ public class PinotSortExchangeCopyRule extends RelRule<RelRule.Config> { | |||
|
|
|||
| public static final PinotSortExchangeCopyRule SORT_EXCHANGE_COPY = | |||
| PinotSortExchangeCopyRule.Config.DEFAULT.toRule(); | |||
| private static final int DEFAULT_SORT_EXCHANGE_COPY_THRESHOLD = 10_000; | |||
There was a problem hiding this comment.
10_000 is a reasonable heuristic until we get a config/hint.
There was a problem hiding this comment.
is it worth to make this configurable as a query param?
There was a problem hiding this comment.
probably. but i haven't decided whether to use a hint or use a query param. so for now i will keep this as a default and if we need to support configuration we will do that then.
walterddr
force-pushed
the
bugfix_skip_local_sort
branch
from
241918e
to
9f8b95b
Compare
xiangfu0
approved these changes
Jan 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12237 +/- ##
============================================
- Coverage 61.53% 61.52% -0.02%
Complexity 207 207
============================================
Files 2416 2416
Lines 131177 131181 +4
Branches 20245 20246 +1
============================================
- Hits 80717 80704 -13
- Misses 44570 44585 +15
- Partials 5890 5892 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saurabhd336
pushed a commit
to saurabhd336/pinot
that referenced
this pull request
Feb 9, 2024
Co-authored-by: Rong Rong <rongr@startree.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logical sort should not be copied when there's no fetch or fetch limit is too large.
this solves part 1 of #12228
follow up separately later