Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support table suffix in ZkBasicAuthAccessControlFactory #12310

Merged

Conversation

xiangfu0
Copy link
Contributor

This is to support _OFFLINE and _REALTIME suffix for querying table.

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f1fec06) 61.56% compared to head (4f1becf) 61.62%.
Report is 2 commits behind head on master.

Files Patch % Lines
...er/api/access/ZkBasicAuthAccessControlFactory.java 0.00% 2 Missing ⚠️
...broker/broker/ZkBasicAuthAccessControlFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #12310      +/-   ##
============================================
+ Coverage     61.56%   61.62%   +0.05%     
  Complexity     1152     1152              
============================================
  Files          2417     2417              
  Lines        131603   131612       +9     
  Branches      20312    20316       +4     
============================================
+ Hits          81025    81107      +82     
+ Misses        44627    44555      -72     
+ Partials       5951     5950       -1     
Flag Coverage Δ
custom-integration1 <0.01% <0.00%> (ø)
integration <0.01% <0.00%> (ø)
integration1 <0.01% <0.00%> (ø)
integration2 0.00% <0.00%> (ø)
java-11 61.56% <0.00%> (+0.03%) ⬆️
java-21 61.47% <0.00%> (+0.07%) ⬆️
skip-bytebuffers-false 61.60% <0.00%> (+0.05%) ⬆️
skip-bytebuffers-true 61.43% <0.00%> (+0.06%) ⬆️
temurin 61.62% <0.00%> (+0.05%) ⬆️
unittests 61.62% <0.00%> (+0.05%) ⬆️
unittests1 46.68% <ø> (+0.07%) ⬆️
unittests2 27.78% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@INNOCENT-BOY
Copy link
Contributor

The previous assumption during the RBAC (Role-Based Access Control) development was that regular users (referring to users without permissions for all tables) should be agnostic to the types of tables. Based on some user feedback, this patch has opened up this permission for them.

@xiangfu0
Copy link
Contributor Author

The previous assumption during the RBAC (Role-Based Access Control) development was that regular users (referring to users without permissions for all tables) should be agnostic to the types of tables. Based on some user feedback, this patch has opened up this permission for them.

👍

@xiangfu0 xiangfu0 merged commit 63e91ef into apache:master Jan 23, 2024
19 checks passed
@xiangfu0 xiangfu0 deleted the support_table_suffix_in_zk_basic_auth branch January 23, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants