Making taskManager resources protected for derived classes to use #12335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in their setUp() method.
|
@snleee - Please review. |
swaminathanmanish
changed the title
snleee
approved these changes
Jan 29, 2024
suyashpatel98
pushed a commit
to suyashpatel98/pinot
that referenced
this pull request
Feb 28, 2024
…e in their setUp() method. (apache#12335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR:
UpsertTableIntegrationTest is a public class which has been extended to implement custom tests with its own setUp() methods. (outside OSS). Making minion resource handles protected for subclasses to override.
Why its needed:
Since derived classes that extend UpsertTableIntegrationTest can override setUp() methods, we want the ability to instantiate minion resource handles as well (pinotTaskManager, PinotHelixTaskResourceManager). The derived classes will also be able to use these handles for their tests.