upgrade maven-shade-plugin version to 3.5.2 #12712
Conversation
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
4 times, most recently
from
34c0fbc
to
07f55c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12712 +/- ##
============================================
+ Coverage 61.75% 62.17% +0.42%
+ Complexity 207 198 -9
============================================
Files 2436 2502 +66
Lines 133233 136486 +3253
Branches 20636 21122 +486
============================================
+ Hits 82274 84866 +2592
- Misses 44911 45357 +446
- Partials 6048 6263 +215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
from
07f55c5
to
4eddca6
Compare
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
9 times, most recently
from
bba0e19
to
1e727fc
Compare
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
from
1e727fc
to
0c8d28c
Compare
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
3 times, most recently
from
79a56b2
to
15b556f
Compare
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
2 times, most recently
from
d4a892a
to
736360f
Compare
| @@ -214,7 +214,6 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-shade-plugin</artifactId> | |||
| <version>3.1.0</version> | |||
There was a problem hiding this comment.
Do we need to keep this plugin? I guess we should never package pinot-perf?
There was a problem hiding this comment.
this is not packaged to pinot-distribution, it's trying to generate another main class for perf testing.
| @@ -35,6 +35,6 @@ | |||
| <url>https://pinot.apache.org/</url> | |||
| <properties> | |||
| <pinot.root>${basedir}/../../..</pinot.root> | |||
| <phase.prop>none</phase.prop> | |||
| <shade.phase.prop>none</shade.phase.prop> | |||
| <id>build-shaded-jar</id> | ||
| <activation> | ||
| <property> | ||
| <name>skipShade</name> |
There was a problem hiding this comment.
Do we want to keep this option in the main pom?
There was a problem hiding this comment.
I don't see the usage for this for a while.
| @@ -2209,6 +2211,9 @@ | |||
| <!-- Exclude build targets --> | |||
| <exclude>**/target/**</exclude> | |||
|
|
|||
| <!-- Exclude Maven plugin generated files --> | |||
| <exclude>**/dependency-reduced-pom.xml</exclude> | |||
There was a problem hiding this comment.
I never saw this file generated
There was a problem hiding this comment.
new version plugin generates this file
xiangfu0
force-pushed
the
upgrade-maven-shade-plugin-version
branch
from
736360f
to
2e74761
Compare
| <profiles> | ||
| <profile> | ||
| <id>build-shaded-jar</id> | ||
| <activation> | ||
| <activeByDefault>false</activeByDefault> | ||
| </activation> |
There was a problem hiding this comment.
After removing this these module level profile the mvn build stopped to publish shaded jars for spi which is required by our build pipeline. We should probably add it back.
Upgrade maven-shade-plugin version from 3.2.x to 3.5.2.
By default, modules are not building the shaded jar.
For the modules require shaded jars, users can specify
<shade.phase.prop>package</shade.phase.prop>in thepom.xmlfilepropertiessection.