Cleanup deprecated query options

[Jackie-Jiang]

• Cleanup the deprecated debug options, and old PQL related query options
• Fix the double query parsing in multi-stage engine
• Fix the inconsistent behavior when query parsing fails: do not log or emit metric because it is pure user error

[Jackie-Jiang]

This is an important fix. Currently we are not passing the parsed SQL into the multi-stage engine, which results in parsing the query twice

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 30.43478% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 62.05%. Comparing base (59551e4) to head (d581631).
Report is 392 commits behind head on master.

Files	Patch %	Lines
...pache/pinot/common/utils/request/RequestUtils.java	0.00%	3 Missing and 2 partials ⚠️
...roker/requesthandler/BaseBrokerRequestHandler.java	42.85%	3 Missing and 1 partial ⚠️
...requesthandler/MultiStageBrokerRequestHandler.java	42.85%	3 Missing and 1 partial ⚠️
...r/requesthandler/BrokerRequestHandlerDelegate.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #13040      +/-   ##
============================================
+ Coverage     61.75%   62.05%   +0.30%     
+ Complexity      207      198       -9     
============================================
  Files          2436     2502      +66     
  Lines        133233   136656    +3423     
  Branches      20636    21178     +542     
============================================
+ Hits          82274    84800    +2526     
- Misses        44911    45558     +647     
- Partials       6048     6298     +250     

Flag	Coverage Δ
custom-integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration	<0.01% <0.00%> (-0.01%)	⬇️
integration1	<0.01% <0.00%> (-0.01%)	⬇️
integration2	0.00% <0.00%> (ø)
java-11	27.95% <26.08%> (-33.76%)	⬇️
java-21	62.05% <30.43%> (+0.42%)	⬆️
skip-bytebuffers-false	62.02% <30.43%> (+0.28%)	⬆️
skip-bytebuffers-true	62.04% <30.43%> (+34.31%)	⬆️
temurin	62.05% <30.43%> (+0.30%)	⬆️
unittests	62.04% <30.43%> (+0.30%)	⬆️
unittests1	46.54% <16.66%> (-0.35%)	⬇️
unittests2	27.95% <26.08%> (+0.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gortiz]

LGTM, but there are multiple tests failing, so I guess we would need to fix something else

[Jackie-Jiang]

LGTM, but there are multiple tests failing, so I guess we would need to fix something else

Find the reason. Currently we only set query option when it is not empty, but the following code assume it is always set. After removing the deprecated options it breaks. Changed the code to always set the query option even if it is empty.