Optimize ExpressionFilterOperator #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
expression_doc_id_set
branch
from
129be8e
to
16e1e55
Compare
Jackie-Jiang
force-pushed
the
expression_doc_id_set
branch
from
16e1e55
to
7359aa3
Compare
1. Add BYTES type and multi-value support 2. Directly consturct DocIdSet to save the overhead of filtering 3. Remove the redundant isMatch() for all scan based iterators Also changed the numEntriesScannedInFilter for MV column to actual values fetched instead of values evaluated and added some TODOs for future filter optimization
Jackie-Jiang
force-pushed
the
expression_doc_id_set
branch
from
7359aa3
to
aaa35fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #5132 +/- ##
============================================
- Coverage 65.90% 65.87% -0.04%
Complexity 12 12
============================================
Files 1052 1056 +4
Lines 54170 54027 -143
Branches 8078 8045 -33
============================================
- Hits 35702 35591 -111
+ Misses 15819 15802 -17
+ Partials 2649 2634 -15
Continue to review full report at Codecov.
|
kishoreg
approved these changes
Apr 3, 2020
|
|
||
| public DocIdSetOperator(@Nonnull BaseFilterOperator filterOperator, int maxSizeOfDocIdSet, boolean threadLocal) { | ||
| public DocIdSetOperator(BaseFilterOperator filterOperator, int maxSizeOfDocIdSet) { |
There was a problem hiding this comment.
this was needed rt. @fx19880617
There was a problem hiding this comment.
This is good.
The DocIdSet creation logic is moved outside.
See https://github.com/apache/incubator-pinot/pull/5132/files#diff-48213157488bdb6aa43c2f6da8d2a940R131
xiangfu0
approved these changes
Apr 3, 2020
Jackie-Jiang
added a commit
to Jackie-Jiang/pinot
that referenced
this pull request
May 4, 2020
…Match() is still required ScanBasedDocIdIterator.isMatch() is still required when the query is in the following format: SELECT ... WHERE (filterA OR filterB) AND filterC And filterC is working on a scan-based column (column without inverted index) Enhance the HybridClusterIntegrationTest to catch this issue
Jackie-Jiang
added a commit
that referenced
this pull request
May 5, 2020
…) is still required (#5328) ScanBasedDocIdIterator.isMatch() is still required when the query is in the following format: SELECT ... WHERE (filterA OR filterB) AND filterC And filterC is working on a scan-based column (column without inverted index) Enhance the HybridClusterIntegrationTest to catch this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed the numEntriesScannedInFilter for MV column to actual values fetched instead of values evaluated and added some TODOs for future filter optimization