Optimize RealtimeDictionaryBasedRangePredicateEvaluator by not scanning the dictionary when cardinality is high #5331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishoreg
approved these changes
May 5, 2020
xiangfu0
reviewed
May 5, 2020
| } else { | ||
| _dictIdSetBased = false; | ||
| _matchingDictIdSet = null; | ||
| switch (dataType) { |
There was a problem hiding this comment.
Not related to this PR, just shall we start thinking of how to simplify those switch cases code blocks?
…ng the dictionary when cardinality is high For real-time range predicate, because the dictionary is not sorted, in order to get the matching dictionary ids, we have to scan the whole dictionary. This will cause performance issue when the cardinality is high for the column. Optimize it by adding a cardinality threshold (1000 for now) to decide whether to pre-calculate all the matching dictionary ids.
Jackie-Jiang
force-pushed
the
optimize_realtime_range_evaluator
branch
from
ec03154
to
021e062
Compare
Codecov Report
@@ Coverage Diff @@
## master #5331 +/- ##
==========================================
- Coverage 66.08% 56.83% -9.25%
==========================================
Files 1072 1072
Lines 54668 54723 +55
Branches 8152 8160 +8
==========================================
- Hits 36125 31104 -5021
- Misses 15895 21174 +5279
+ Partials 2648 2445 -203
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For real-time range predicate, because the dictionary is not sorted, in order to get the matching dictionary ids, we have to scan the whole dictionary.
This will cause performance issue when the cardinality is high for the column.
Optimize it by adding a cardinality threshold (1000 for now) to decide whether to pre-calculate all the matching dictionary ids.