Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused TimeFieldSpec related methods from Schema #5347

Merged
merged 3 commits into from
May 7, 2020

Conversation

npawar
Copy link
Contributor

@npawar npawar commented May 7, 2020

Another step towards: #2756

As I was making changes to Schema to treat TIME as DATE_TIME, found a subset of changes that can go prior to the bigger change.
Removing 3 methods from the Schema which are related to TimeFieldSpec

  1. getIncomingTimeUnit - was unused
  2. getOutgoingTimeUnit - was unused
  3. getTimeColumnName - was able to remove the 4 usages

…reserve order, which is used in record reader
Copy link
Contributor

@mcvsubbu mcvsubbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm other than minor comment

@codecov-io
Copy link

Codecov Report

Merging #5347 into master will decrease coverage by 0.06%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5347      +/-   ##
==========================================
- Coverage   66.51%   66.45%   -0.07%     
==========================================
  Files        1075     1075              
  Lines       54780    54757      -23     
  Branches     8171     8165       -6     
==========================================
- Hits        36438    36387      -51     
- Misses      15656    15705      +49     
+ Partials     2686     2665      -21     
Impacted Files Coverage Δ
...ore/minion/rollup/MergeRollupSegmentConverter.java 89.28% <66.66%> (ø)
.../core/indexsegment/mutable/MutableSegmentImpl.java 76.38% <70.00%> (+2.32%) ⬆️
.../columnminmaxvalue/ColumnMinMaxValueGenerator.java 70.00% <100.00%> (-0.43%) ⬇️
...rc/main/java/org/apache/pinot/spi/data/Schema.java 75.17% <100.00%> (+0.08%) ⬆️
...ller/validation/OfflineSegmentIntervalChecker.java 29.48% <0.00%> (-53.85%) ⬇️
...apache/pinot/common/metrics/ValidationMetrics.java 47.45% <0.00%> (-28.82%) ⬇️
.../impl/dictionary/FloatOnHeapMutableDictionary.java 63.41% <0.00%> (-13.42%) ⬇️
...he/pinot/controller/util/SegmentIntervalUtils.java 0.00% <0.00%> (-8.34%) ⬇️
.../org/apache/pinot/core/startree/StarTreeUtils.java 81.08% <0.00%> (-5.41%) ⬇️
...rg/apache/pinot/broker/routing/RoutingManager.java 78.62% <0.00%> (-3.44%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 589b1aa...e442fb8. Read the comment docs.

@npawar npawar merged commit bfd263a into apache:master May 7, 2020
@npawar npawar deleted the remove_unused_methods_from_schema branch May 7, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants