Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeColumnName and schema to all Integration test tables #5369

Closed
wants to merge 3 commits into from

Conversation

npawar
Copy link
Contributor

@npawar npawar commented May 12, 2020

#2756
Providing timecolumnName to SegmentTestUtils.getSegmentGeneratorConfig, so that we dont have to call getTimeFieldSpec.

@npawar npawar requested a review from Jackie-Jiang May 12, 2020 01:37
@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #5369 into master will decrease coverage by 9.44%.
The diff coverage is 42.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5369      +/-   ##
==========================================
- Coverage   66.44%   57.00%   -9.45%     
==========================================
  Files        1075     1079       +4     
  Lines       54773    55035     +262     
  Branches     8168     8227      +59     
==========================================
- Hits        36396    31370    -5026     
- Misses      15700    21201    +5501     
+ Partials     2677     2464     -213     
Impacted Files Coverage Δ
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <ø> (-80.00%) ⬇️
...e/data/manager/realtime/SplitSegmentCommitter.java 0.00% <ø> (-63.64%) ⬇️
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 90.69% <ø> (+1.80%) ⬆️
...inot/spi/ingestion/batch/IngestionJobLauncher.java 0.00% <0.00%> (ø)
...manager/realtime/LLRealtimeSegmentDataManager.java 48.00% <38.46%> (-21.21%) ⬇️
...che/pinot/spi/stream/StreamPartitionMsgOffset.java 87.50% <87.50%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 57.40% <100.00%> (-7.41%) ⬇️
...ot/core/segment/index/metadata/ColumnMetadata.java 73.79% <100.00%> (ø)
...pache/pinot/plugin/inputformat/avro/AvroUtils.java 66.94% <100.00%> (ø)
...a/org/apache/pinot/minion/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
... and 340 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d54afba...a5e1e5c. Read the comment docs.

@npawar npawar changed the title TimeColumnName in SegmentTestUtils.getSegmentGeneratorConfig TimeColumnName and schema to all Integration test tables May 12, 2020
@npawar npawar requested a review from mcvsubbu May 12, 2020 18:04
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to make it use table config and schema

@npawar npawar closed this May 15, 2020
@npawar npawar deleted the timecolumn_in_integration_tests branch May 15, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants