Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TE] clean up decprecated/unused code #5435

Merged
merged 6 commits into from
Jun 4, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,33 +20,23 @@
package org.apache.pinot.thirdeye.anomaly;

import com.fasterxml.jackson.databind.SerializationFeature;
import org.apache.pinot.thirdeye.anomaly.alert.v2.AlertJobSchedulerV2;
import org.apache.pinot.thirdeye.anomaly.classification.ClassificationJobScheduler;
import org.apache.pinot.thirdeye.anomaly.classification.classifier.AnomalyClassifierFactory;
import org.apache.pinot.thirdeye.anomaly.detection.DetectionJobScheduler;
import org.apache.pinot.thirdeye.anomaly.detection.trigger.DataAvailabilityEventListenerDriver;
import org.apache.pinot.thirdeye.anomaly.detection.trigger.DataAvailabilityTaskScheduler;
import org.apache.pinot.thirdeye.anomaly.events.HolidayEventResource;
import org.apache.pinot.thirdeye.anomaly.events.HolidayEventsLoader;
import org.apache.pinot.thirdeye.anomaly.events.MockEventsLoader;
import org.apache.pinot.thirdeye.anomaly.monitor.MonitorJobScheduler;
import org.apache.pinot.thirdeye.anomaly.task.TaskDriver;
import org.apache.pinot.thirdeye.anomalydetection.alertFilterAutotune.AlertFilterAutotuneFactory;
import org.apache.pinot.thirdeye.common.time.TimeGranularity;
import org.apache.pinot.thirdeye.auto.onboard.AutoOnboardService;
import org.apache.pinot.thirdeye.common.BaseThirdEyeApplication;
import org.apache.pinot.thirdeye.common.ThirdEyeSwaggerBundle;
import org.apache.pinot.thirdeye.completeness.checker.DataCompletenessScheduler;
import org.apache.pinot.thirdeye.dashboard.resources.DetectionJobResource;
import org.apache.pinot.thirdeye.dashboard.resources.EmailResource;
import org.apache.pinot.thirdeye.datasource.DAORegistry;
import org.apache.pinot.thirdeye.datasource.ThirdEyeCacheRegistry;
import org.apache.pinot.thirdeye.datasource.pinot.resources.PinotDataSourceResource;
import org.apache.pinot.thirdeye.model.download.ModelDownloaderManager;
import org.apache.pinot.thirdeye.scheduler.DetectionCronScheduler;
import org.apache.pinot.thirdeye.scheduler.SubscriptionCronScheduler;
import org.apache.pinot.thirdeye.detector.email.filter.AlertFilterFactory;
import org.apache.pinot.thirdeye.detector.function.AnomalyFunctionFactory;
import org.apache.pinot.thirdeye.tracking.RequestStatisticsLogger;
import io.dropwizard.assets.AssetsBundle;
import io.dropwizard.lifecycle.Managed;
Expand All @@ -61,18 +51,9 @@
public class ThirdEyeAnomalyApplication
extends BaseThirdEyeApplication<ThirdEyeAnomalyConfiguration> {

private DetectionJobScheduler detectionJobScheduler = null;
private TaskDriver taskDriver = null;
private MonitorJobScheduler monitorJobScheduler = null;
private AlertJobSchedulerV2 alertJobSchedulerV2;
private AnomalyFunctionFactory anomalyFunctionFactory = null;
private AutoOnboardService autoOnboardService = null;
private DataCompletenessScheduler dataCompletenessScheduler = null;
private AlertFilterFactory alertFilterFactory = null;
private AnomalyClassifierFactory anomalyClassifierFactory = null;
private AlertFilterAutotuneFactory alertFilterAutotuneFactory = null;
private ClassificationJobScheduler classificationJobScheduler = null;
private EmailResource emailResource = null;
private HolidayEventsLoader holidayEventsLoader = null;
private MockEventsLoader mockEventsLoader = null;
private RequestStatisticsLogger requestStatisticsLogger = null;
Expand Down Expand Up @@ -134,33 +115,13 @@ public void start() throws Exception {
requestStatisticsLogger.start();

if (config.isWorker()) {
initAnomalyFunctionFactory(config.getFunctionConfigPath());
initAlertFilterFactory(config.getAlertFilterConfigPath());
initAnomalyClassifierFactory(config.getAnomalyClassifierConfigPath());

taskDriver = new TaskDriver(config, anomalyFunctionFactory, alertFilterFactory, anomalyClassifierFactory);
taskDriver = new TaskDriver(config);
taskDriver.start();
}
if (config.isScheduler()) {
initAnomalyFunctionFactory(config.getFunctionConfigPath());
initAlertFilterFactory(config.getAlertFilterConfigPath());
initAlertFilterAutotuneFactory(config.getFilterAutotuneConfigPath());

emailResource = new EmailResource(config);
detectionJobScheduler = new DetectionJobScheduler();
detectionJobScheduler.start();
environment.jersey().register(
new DetectionJobResource(detectionJobScheduler, alertFilterFactory, alertFilterAutotuneFactory, emailResource));
}
if (config.isMonitor()) {
monitorJobScheduler = new MonitorJobScheduler(config.getMonitorConfiguration());
monitorJobScheduler.start();
}
if (config.isAlert()) {
// start alert scheduler v2
alertJobSchedulerV2 = new AlertJobSchedulerV2();
alertJobSchedulerV2.start();
}
if (config.isAutoload()) {
autoOnboardService = new AutoOnboardService(config);
autoOnboardService.start();
Expand All @@ -176,14 +137,6 @@ public void start() throws Exception {
mockEventsLoader = new MockEventsLoader(config.getMockEventsLoaderConfiguration(), DAORegistry.getInstance().getEventDAO());
mockEventsLoader.run();
}
if (config.isDataCompleteness()) {
dataCompletenessScheduler = new DataCompletenessScheduler();
dataCompletenessScheduler.start();
}
if (config.isClassifier()) {
classificationJobScheduler = new ClassificationJobScheduler();
classificationJobScheduler.start();
}
if (config.isPinotProxy()) {
environment.jersey().register(new PinotDataSourceResource());
}
Expand Down Expand Up @@ -221,27 +174,15 @@ public void stop() throws Exception {
if (taskDriver != null) {
taskDriver.shutdown();
}
if (detectionJobScheduler != null) {
detectionJobScheduler.shutdown();
}
if (monitorJobScheduler != null) {
monitorJobScheduler.shutdown();
}
if (holidayEventsLoader != null) {
holidayEventsLoader.shutdown();
}
if (alertJobSchedulerV2 != null) {
alertJobSchedulerV2.shutdown();
}
if (autoOnboardService != null) {
autoOnboardService.shutdown();
}
if (dataCompletenessScheduler != null) {
dataCompletenessScheduler.shutdown();
}
if (classificationJobScheduler != null) {
classificationJobScheduler.shutdown();
}
if (detectionScheduler != null) {
detectionScheduler.shutdown();
}
Expand All @@ -254,28 +195,4 @@ public void stop() throws Exception {
}
});
}

private void initAnomalyFunctionFactory(String functoinConfigPath) {
if (anomalyFunctionFactory == null) {
anomalyFunctionFactory = new AnomalyFunctionFactory(functoinConfigPath);
}
}

private void initAlertFilterFactory(String alertFilterConfigPath) {
if (alertFilterFactory == null) {
alertFilterFactory = new AlertFilterFactory(alertFilterConfigPath);
}
}

private void initAnomalyClassifierFactory(String anomalyClassifierConfigPath) {
if (anomalyClassifierFactory == null) {
anomalyClassifierFactory = new AnomalyClassifierFactory(anomalyClassifierConfigPath);
}
}

private void initAlertFilterAutotuneFactory(String filterAutotuneConfigPath) {
if (alertFilterAutotuneFactory == null) {
alertFilterAutotuneFactory = new AlertFilterAutotuneFactory(filterAutotuneConfigPath);
}
}
}

This file was deleted.

This file was deleted.