Zookeeper put api #5949
Merged
Zookeeper put api #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishoreg
force-pushed
the
zookeeper-put-api
branch
from
418b6ad
to
d3e86ad
Compare
mayankshriv
reviewed
Sep 13, 2020
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ZookeeperResource.java
Show resolved
Hide resolved
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ZookeeperResource.java
Outdated
Show resolved
Hide resolved
| @@ -75,6 +80,63 @@ public String getData( | |||
| return null; | |||
| } | |||
|
|
|||
| @DELETE | |||
| @Path("/zk/delete") | |||
There was a problem hiding this comment.
The delete api seems a bit dangerous. Should we protect it to only allow deleting certain paths? Seems this api will allow deleting the entire cluster?
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ZookeeperResource.java
Show resolved
Hide resolved
|
@sajjad-moradi You may want to take into account these apis when adding ACL checks. |
mayankshriv
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an api to update ZK Path. Will be used by the UI
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document