Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Update & Delete in ZooKeeper Browser and added SQL Functions in SQL Editor autocomplete list #5981

Merged
merged 5 commits into from Sep 15, 2020

Conversation

shahsank3t
Copy link
Contributor

Description

Added support for Update & Delete in Zookeeper Browser.
image

image

Added SQL Functions in SQL Editor's autocomplete list.
image

@kishoreg
Copy link
Member

kishoreg commented Sep 8, 2020

Tested it and it works fine. Few things

  • Ask for confirmation before saving instead of before editing
  • Refresh seems to refresh the entire tree, just refresh the path that is selected
  • display the refresh time on the top (maintain this for each node)

@shahsank3t
Copy link
Contributor Author

@kishoreg Addressed your feedback and also added Success & Error Notification Alerts on completion of Update/Delete Operation.

Copy link
Member

@kishoreg kishoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@shahsank3t
Copy link
Contributor Author

@kishoreg rebased and all checks passed.

@kishoreg kishoreg merged commit 5da3433 into apache:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants