Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce 'LOOKUP' Transform Function #6383

Merged
merged 9 commits into from
Jan 8, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public enum TransformFunctionType {
VALUEIN("valueIn"),
MAPVALUE("mapValue"),
INIDSET("inIdSet"),
LOOKUP("lookUp"),
GROOVY("groovy"),
// Special type for annotation based scalar functions
SCALAR("scalar"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.pinot.core.data.manager.offline;

import com.google.common.annotations.VisibleForTesting;
import java.io.File;
import java.util.HashMap;
import java.util.List;
Expand Down Expand Up @@ -64,6 +65,11 @@ public static DimensionTableDataManager createInstanceByTableName(String tableNa
return _instances.computeIfAbsent(tableNameWithType, k -> new DimensionTableDataManager());
}

@VisibleForTesting
public static DimensionTableDataManager registerDimensionTable(String tableNameWithType, DimensionTableDataManager instance) {
return _instances.computeIfAbsent(tableNameWithType, k -> instance);
}

public static DimensionTableDataManager getInstanceByTableName(String tableNameWithType) {
return _instances.get(tableNameWithType);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,290 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pinot.core.operator.transform.function;

import java.util.Arrays;
import java.util.List;
import java.util.Map;
import java.util.ArrayList;
import com.google.common.base.Preconditions;
import org.apache.commons.lang3.ArrayUtils;
import org.apache.pinot.core.common.DataSource;
import org.apache.pinot.core.data.manager.offline.DimensionTableDataManager;
import org.apache.pinot.core.operator.blocks.ProjectionBlock;
import org.apache.pinot.core.operator.transform.TransformResultMetadata;
import org.apache.pinot.spi.data.FieldSpec;
import org.apache.pinot.spi.data.readers.GenericRow;
import org.apache.pinot.spi.data.readers.PrimaryKey;


/**
* LOOKUP function takes 4 or more arguments:
* <ul>
* <li><b>TableName:</b> name of the dimension table which will be used</li>
* <li><b>ColumnName:</b> column name from the dimension table to look up</li>
* <li><b>JoinKey:</b> primary key column name for the dimension table. Note: Only primary key[s] are supported for JoinKey</li>
* <li><b>JoinValue:</b> primary key value</li>
* ...<br>
* *[If the dimension table has more then one primary keys (composite pk)]
* <li><b>JoinKey2</b></li>
* <li><b>JoinValue2</b></li>
* ...
* </ul>
* <br>
* Example:
* <pre>{@code SELECT
* baseballStats.playerName,
* baseballStats.teamID,
* LOOKUP('dimBaseballTeams', 'teamName', 'teamID', baseballStats.teamID)
* FROM
* baseballStats
* LIMIT 10}</pre>
* <br>
* Above example joins the dimension table 'baseballTeams' into regular table 'baseballStats' on 'teamID' key.
cbalci marked this conversation as resolved.
Show resolved Hide resolved
* Lookup function returns the value of the column 'teamName'.
*/
public class LookupTransformFunction extends BaseTransformFunction {
public static final String FUNCTION_NAME = "lookUp";
private static final String TABLE_NAME_SUFFIX = "_OFFLINE";
cbalci marked this conversation as resolved.
Show resolved Hide resolved

// Lookup parameters
private String _dimTableName;
private String _dimColumnName;
private final List<String> _joinKeys = new ArrayList<>();
private final List<FieldSpec> _joinValueFieldSpecs = new ArrayList<>();
private final List<TransformFunction> _joinValueFunctions = new ArrayList<>();

private DimensionTableDataManager _dataManager;
private FieldSpec _lookupColumnFieldSpec;

@Override
public String getName() {
return FUNCTION_NAME;
}

@Override
public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) {
// Check that there are correct number of arguments
Preconditions
.checkArgument(arguments.size() >= 4, "At least 4 arguments are required for LOOKUP transform function");
cbalci marked this conversation as resolved.
Show resolved Hide resolved
Preconditions
.checkArgument(arguments.size() % 2 == 0, "Should have the same number of JoinKey and JoinValue arguments");

TransformFunction dimTableNameFunction = arguments.get(0);
Preconditions.checkArgument(dimTableNameFunction instanceof LiteralTransformFunction,
"First argument must be a literal(string) representing the dimension table name");
_dimTableName = ((LiteralTransformFunction) dimTableNameFunction).getLiteral();
cbalci marked this conversation as resolved.
Show resolved Hide resolved

TransformFunction dimColumnFunction = arguments.get(1);
Preconditions.checkArgument(dimColumnFunction instanceof LiteralTransformFunction,
"Second argument must be a literal(string) representing the column name from dimension table to lookup");
_dimColumnName = ((LiteralTransformFunction) dimColumnFunction).getLiteral();

List<TransformFunction> joinArguments = arguments.subList(2, arguments.size());
for (int i = 0; i < joinArguments.size() / 2; i++) {
cbalci marked this conversation as resolved.
Show resolved Hide resolved
TransformFunction dimJoinKeyFunction = joinArguments.get((i * 2));
Preconditions.checkArgument(dimJoinKeyFunction instanceof LiteralTransformFunction,
"JoinKey argument must be a literal(string) representing the primary key for the dimension table");
_joinKeys.add(((LiteralTransformFunction) dimJoinKeyFunction).getLiteral());

TransformFunction factJoinValueFunction = joinArguments.get((i * 2) + 1);
TransformResultMetadata factJoinValueFunctionResultMetadata = factJoinValueFunction.getResultMetadata();
Preconditions.checkArgument(factJoinValueFunctionResultMetadata.isSingleValue(),
"JoinValue argument must be a single value expression");
_joinValueFunctions.add(factJoinValueFunction);
}

// Validate lookup table and relevant columns
_dataManager = DimensionTableDataManager.getInstanceByTableName(_dimTableName + TABLE_NAME_SUFFIX);
Preconditions
.checkArgument(_dataManager != null, String.format("Dimension table does not exist: %s", _dimTableName));

_lookupColumnFieldSpec = _dataManager.getColumnFieldSpec(_dimColumnName);
Preconditions.checkArgument(_lookupColumnFieldSpec != null,
String.format("Column does not exist in dimension table: %s:%s", _dimTableName, _dimColumnName));

for (String joinKey : _joinKeys) {
FieldSpec pkColumnSpec = _dataManager.getColumnFieldSpec(joinKey);
Preconditions.checkArgument(pkColumnSpec != null,
String.format("Primary key column doesn't exist in dimension table: %s:%s", _dimTableName, joinKey));
_joinValueFieldSpecs.add(pkColumnSpec);
}
}

@Override
public TransformResultMetadata getResultMetadata() {
return new TransformResultMetadata(_lookupColumnFieldSpec.getDataType(),
_lookupColumnFieldSpec.isSingleValueField(), false);
}

private Object[] lookup(ProjectionBlock projectionBlock) {
int numPkColumns = _joinKeys.size();
int numDocuments = projectionBlock.getNumDocs();
Object[][] pkColumns = new Object[numPkColumns][];
for (int i = 0; i < numPkColumns; i++) {
FieldSpec.DataType colType = _joinValueFieldSpecs.get(i).getDataType();
TransformFunction tf = _joinValueFunctions.get(i);
switch (colType) {
cbalci marked this conversation as resolved.
Show resolved Hide resolved
case STRING:
cbalci marked this conversation as resolved.
Show resolved Hide resolved
pkColumns[i] = tf.transformToStringValuesSV(projectionBlock);
break;
case INT:
pkColumns[i] = ArrayUtils.toObject(tf.transformToIntValuesSV(projectionBlock));
break;
case LONG:
pkColumns[i] = ArrayUtils.toObject(tf.transformToLongValuesSV(projectionBlock));
break;
default:
throw new IllegalStateException("Unknown column type for primary key");
}
}

Object[] resultSet = new Object[numDocuments];
for (int i = 0; i < numDocuments; i++) {
// prepare pk
Object[] pkValues = new Object[numPkColumns];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reuse this Object[] instead of creating a new one per iteration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do something like:

  Object[] resultSet = new Object[numDocuments];
  Object[] pkValues = new Object[numPkColumns];
  for (int i = 0; i < numDocuments; i++) {
    // prepare pk
    for (int j = 0; j < numPkColumns; j++) {
      pkValues[j] = pkColumns[j][i];
    }
    // lookup
    GenericRow row = _dataManager.lookupRowByPrimaryKey(new PrimaryKey(pkValues));
    if (row != null) {
      resultSet[i] = row.getValue(_dimColumnName);
    }
  }

I don't see much point in doing the same for PrimaryKey though. We will only be reusing the pointer which is not really helpful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will reuse the object instead of creating one per doc:

  Object[] resultSet = new Object[numDocuments];
  Object[] pkValues = new Object[numPkColumns];
  PrimaryKey primaryKey = new PrimaryKey(pkValues);
  for (int i = 0; i < numDocuments; i++) {
    ...

Copy link
Contributor Author

@cbalci cbalci Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work. We have to create a new 'PrimaryKey' instance per document since the values (pkValues) are going to be different.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang Dec 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly modify pkValues without changing primaryKey. They share the same reference.
This is not critical, so both ways are fine. It just saves minor garbages

for (int j = 0; j < numPkColumns; j++) {
pkValues[j] = pkColumns[j][i];
}
// lookup
GenericRow row = _dataManager.lookupRowByPrimaryKey(new PrimaryKey(pkValues));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PrimaryKey object can also be reused

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied above

if (row != null && row.getFieldToValueMap().containsKey(_dimColumnName)) {
resultSet[i] = row.getValue(_dimColumnName);
}
cbalci marked this conversation as resolved.
Show resolved Hide resolved
}
return resultSet;
}

@Override
public int[] transformToIntValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
int[] resultSet = new int[lookupObjects.length];
Arrays.fill(resultSet, ((Number) _lookupColumnFieldSpec.getDefaultNullValue()).intValue());
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = ((Number) lookupObjects[i]).intValue();
cbalci marked this conversation as resolved.
Show resolved Hide resolved
}
return resultSet;
}

@Override
public long[] transformToLongValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
long[] resultSet = new long[lookupObjects.length];
Arrays.fill(resultSet, ((Number) _lookupColumnFieldSpec.getDefaultNullValue()).longValue());
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = ((Number) lookupObjects[i]).longValue();
}
return resultSet;
}

@Override
public float[] transformToFloatValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
float[] resultSet = new float[lookupObjects.length];
Arrays.fill(resultSet, ((Number) _lookupColumnFieldSpec.getDefaultNullValue()).floatValue());
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = ((Number) lookupObjects[i]).floatValue();
}
return resultSet;
}

@Override
public double[] transformToDoubleValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
double[] resultSet = new double[lookupObjects.length];
Arrays.fill(resultSet, ((Number) _lookupColumnFieldSpec.getDefaultNullValue()).doubleValue());
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = ((Number) lookupObjects[i]).doubleValue();
}
return resultSet;
}

@Override
public String[] transformToStringValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
String[] resultSet = new String[lookupObjects.length];
Arrays.fill(resultSet, _lookupColumnFieldSpec.getDefaultNullValueString());
for (int i = 0; i < lookupObjects.length; i++) {
if (lookupObjects[i] != null) {
resultSet[i] = lookupObjects[i].toString();
}
}
return resultSet;
}

@Override
public byte[][] transformToBytesValuesSV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
byte[][] resultSet = new byte[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (byte[]) lookupObjects[i];
}
return resultSet;
}

@Override
public int[][] transformToIntValuesMV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
int[][] resultSet = new int[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (int[]) lookupObjects[i];
}
return resultSet;
}

@Override
public long[][] transformToLongValuesMV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
long[][] resultSet = new long[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (long[]) lookupObjects[i];
}
return resultSet;
}

@Override
public float[][] transformToFloatValuesMV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
float[][] resultSet = new float[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (float[]) lookupObjects[i];
}
return resultSet;
}

@Override
public double[][] transformToDoubleValuesMV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
double[][] resultSet = new double[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (double[]) lookupObjects[i];
}
return resultSet;
}

@Override
public String[][] transformToStringValuesMV(ProjectionBlock projectionBlock) {
Object[] lookupObjects = lookup(projectionBlock);
String[][] resultSet = new String[lookupObjects.length][0];
for (int i = 0; i < lookupObjects.length; i++) {
resultSet[i] = (String[]) lookupObjects[i];
}
return resultSet;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ private TransformFunctionFactory() {
put(canonicalize(TransformFunctionType.VALUEIN.getName().toLowerCase()), ValueInTransformFunction.class);
put(canonicalize(TransformFunctionType.MAPVALUE.getName().toLowerCase()), MapValueTransformFunction.class);
put(canonicalize(TransformFunctionType.INIDSET.getName().toLowerCase()), InIdSetTransformFunction.class);
put(canonicalize(TransformFunctionType.LOOKUP.getName().toLowerCase()), LookupTransformFunction.class);

// Array functions
put(canonicalize(TransformFunctionType.ARRAYAVERAGE.getName().toLowerCase()), ArrayAverageTransformFunction.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,27 @@ protected void testTransformFunctionMV(TransformFunction transformFunction, int[
}
}

protected void testTransformFunctionMV(TransformFunction transformFunction, long[][] expectedValues) {
long[][] longMVValues = transformFunction.transformToLongValuesMV(_projectionBlock);
for (int i = 0; i < NUM_ROWS; i++) {
Assert.assertEquals(longMVValues[i], expectedValues[i]);
}
}

protected void testTransformFunctionMV(TransformFunction transformFunction, float[][] expectedValues) {
float[][] floatMVValues = transformFunction.transformToFloatValuesMV(_projectionBlock);
for (int i = 0; i < NUM_ROWS; i++) {
Assert.assertEquals(floatMVValues[i], expectedValues[i]);
}
}

protected void testTransformFunctionMV(TransformFunction transformFunction, double[][] expectedValues) {
double[][] doubleMVValues = transformFunction.transformToDoubleValuesMV(_projectionBlock);
for (int i = 0; i < NUM_ROWS; i++) {
Assert.assertEquals(doubleMVValues[i], expectedValues[i]);
}
}

protected void testTransformFunctionMV(TransformFunction transformFunction, String[][] expectedValues) {
String[][] stringMVValues = transformFunction.transformToStringValuesMV(_projectionBlock);
for (int i = 0; i < NUM_ROWS; i++) {
Expand Down
Loading