Fix bug #6671: RealtimeTableDataManager shuts down SegmentBuildTimeLeaseExtender for all tables in the host #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
reviewed
Mar 15, 2021
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
jtao15
changed the title
jackjlli
reviewed
Mar 15, 2021
.../test/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManagerTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
jtao15
force-pushed
the
leaseExtender
branch
2 times, most recently
from
7aee81d
to
ada5299
Compare
Codecov Report
@@ Coverage Diff @@
## master #6682 +/- ##
===========================================
- Coverage 66.44% 43.47% -22.98%
===========================================
Files 1075 1388 +313
Lines 54773 67508 +12735
Branches 8168 9792 +1624
===========================================
- Hits 36396 29346 -7050
- Misses 15700 35700 +20000
+ Partials 2677 2462 -215
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Mar 16, 2021
...-core/src/main/java/org/apache/pinot/core/data/manager/offline/TableDataManagerProvider.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Outdated
Show resolved
Hide resolved
jackjlli
approved these changes
Mar 16, 2021
...src/main/java/org/apache/pinot/core/data/manager/realtime/SegmentBuildTimeLeaseExtender.java
Show resolved
Hide resolved
…TimeLeaseExtender for all tables in the host
mcvsubbu
reviewed
Mar 16, 2021
| if (v == null) { | ||
| return new SegmentBuildTimeLeaseExtender(instanceId, serverMetrics, tableNameWithType); | ||
| } else { | ||
| LOGGER.warn("Lease extender for Table: {} already exists", tableNameWithType); |
There was a problem hiding this comment.
Why is this a warning? The method is to getOrCreate(). Getting the extender is perfectly ok. Please change it to INFO or no log at all.
| ServerMetrics serverMetrics, String tableNameWithType) { | ||
| return TABLE_TO_LEASE_EXTENDER.compute(tableNameWithType, (k, v) -> { | ||
| if (v == null) { | ||
| return new SegmentBuildTimeLeaseExtender(instanceId, serverMetrics, tableNameWithType); |
There was a problem hiding this comment.
Add a log here "Creating lease extender for the table {}"
| @@ -91,9 +92,12 @@ public synchronized void init(PinotConfiguration config, HelixManager helixManag | |||
| Preconditions.checkState(instanceSegmentTarDir.mkdirs()); | |||
| } | |||
|
|
|||
| // Initialize segment build time lease extender executor | |||
| SegmentBuildTimeLeaseExtender.initExecutor(); | |||
| LOGGER.info("Initialized segment build time lease extender executor"); | |||
There was a problem hiding this comment.
Move this log to be inside the method initExecutor()
| @@ -108,6 +112,8 @@ public synchronized void shutDown() { | |||
| for (TableDataManager tableDataManager : _tableDataManagerMap.values()) { | |||
| tableDataManager.shutDown(); | |||
| } | |||
| SegmentBuildTimeLeaseExtender.shutdownExecutor(); | |||
| LOGGER.info("Segment build time lease extender executor shut down"); | |||
There was a problem hiding this comment.
Move this log to be inside shutDownExecutor()
xiangfu0
pushed a commit
that referenced
this pull request
Apr 7, 2021
…aseExtender for all tables in the host (#6682) Co-authored-by: Jiapeng Tao <jiatao@jiatao-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr change
SegmentBuildTimeLeaseExtenderfrom instance level to table level, so removing one table will not accidentally shut down theSegmentBuildTimeLeaseExtenderof other tables.