Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache JsonPaths to prevent compilation per segment #7826

Merged
merged 1 commit into from Nov 24, 2021

Conversation

richardstartin
Copy link
Member

This prevents compiling a JsonPath for each queried segment.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #7826 (c77175c) into master (90f5881) will decrease coverage by 6.47%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7826      +/-   ##
============================================
- Coverage     71.66%   65.19%   -6.48%     
+ Complexity     4089     4086       -3     
============================================
  Files          1579     1534      -45     
  Lines         80832    78969    -1863     
  Branches      12010    11807     -203     
============================================
- Hits          57932    51483    -6449     
- Misses        19001    23824    +4823     
+ Partials       3899     3662     -237     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.67% <81.81%> (+0.02%) ⬆️
unittests2 14.59% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/apache/pinot/common/function/JsonPathCache.java 78.57% <77.77%> (-21.43%) ⬇️
...form/function/JsonExtractKeyTransformFunction.java 73.91% <100.00%> (-4.35%) ⬇️
...m/function/JsonExtractScalarTransformFunction.java 43.80% <100.00%> (-5.72%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f5881...c77175c. Read the comment docs.

Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackie-Jiang Jackie-Jiang merged commit eff5351 into apache:master Nov 24, 2021
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants