Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update log4j 2 to avoid CVE-2021-44228 #7889

Merged
merged 1 commit into from
Dec 10, 2021
Merged

update log4j 2 to avoid CVE-2021-44228 #7889

merged 1 commit into from
Dec 10, 2021

Conversation

richardstartin
Copy link
Member

CVE-2021-44228 was announced this morning affecting log4j 2 until 2.15.0. I verified that there are no transitive dependencies on older versions of log4j 2:

mvn dependency:tree | grep log4j                
[INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO]    +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO]    |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO]    |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO]    +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO]    +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO]    |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO]    |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO]    +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  |  \- log4j:log4j:jar:1.2.17:compile
[INFO] |  +- org.slf4j:slf4j-log4j12:jar:1.7.10:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:compile
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:compile
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:runtime
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:compile
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided
[INFO] |     |  \- log4j:log4j:jar:1.2.17:provided
[INFO] |     +- org.slf4j:slf4j-log4j12:jar:1.7.10:provided
[INFO] |  +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.15.0:provided
[INFO] |  |  +- org.apache.logging.log4j:log4j-api:jar:2.15.0:provided
[INFO] |  |  \- org.apache.logging.log4j:log4j-core:jar:2.15.0:provided
[INFO] |  +- org.apache.logging.log4j:log4j-1.2-api:jar:2.15.0:provided

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2021 •
edited

Codecov Report

Merging #7889 (11490c6) into master (24504b3) will decrease coverage by 6.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7889      +/-   ##
============================================
- Coverage     71.40%   65.09%   -6.31%     
- Complexity     4081     4082       +1     
============================================
  Files          1583     1538      -45     
  Lines         81871    80000    -1871     
  Branches      12239    12036     -203     
============================================
- Hits          58458    52076    -6382     
- Misses        19454    24200    +4746     
+ Partials       3959     3724     -235
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.46% <ø> (+<0.01%) ⬆️
unittests2 14.44% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
...t/core/startree/plan/StarTreeDocIdSetPlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ot/common/restlet/resources/TableMetadataInfo.java 0.00% <0.00%> (-100.00%) ⬇️
... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24504b3...11490c6. Read the comment docs.

@mayankshriv mayankshriv merged commit af2858a into apache:master Dec 10, 2021
xiangfu0 pushed a commit that referenced this pull request Dec 12, 2021
@richardstartin @xiangfu0
update log4j 2 to avoid CVE-2021-44228 (#7889)
1579bd0
kriti-sc pushed a commit to kriti-sc/incubator-pinot that referenced this pull request Dec 12, 2021
@richardstartin @kriti-sc
update log4j 2 to avoid CVE-2021-44228 (apache#7889)
3b451ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangfu0 xiangfu0 xiangfu0 approved these changes

@mayankshriv mayankshriv mayankshriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@richardstartin @codecov-commenter @xiangfu0 @mayankshriv