Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing datetime truncate for multi-day #8327

Merged
merged 2 commits into from Mar 9, 2022

Conversation

walterddr
Copy link
Contributor

Fix #8326

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #8327 (4f83ec0) into master (53fa9a5) will decrease coverage by 56.68%.
The diff coverage is 0.00%.

❗ Current head 4f83ec0 differs from pull request most recent head 7e83d1f. Consider uploading reports for the commit 7e83d1f to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8327       +/-   ##
=============================================
- Coverage     70.88%   14.19%   -56.69%     
+ Complexity     4255       81     -4174     
=============================================
  Files          1635     1590       -45     
  Lines         85746    83864     -1882     
  Branches      12912    12708      -204     
=============================================
- Hits          60777    11906    -48871     
- Misses        20792    71059    +50267     
+ Partials       4177      899     -3278     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.19% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...inot/common/function/scalar/DateTimeFunctions.java 0.00% <0.00%> (-95.92%) ⬇️
.../transformer/datetime/BaseDateTimeTransformer.java 0.00% <0.00%> (-93.94%) ⬇️
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1304 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fa9a5...7e83d1f. Read the comment docs.

Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jackie-Jiang Jackie-Jiang merged commit 07a7ddb into apache:master Mar 9, 2022
@walterddr walterddr deleted the fix_datetrunk branch December 6, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATETIMECONVERT (and udf) does not work with multiple days granularity
4 participants