Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] fix server discovery #8664

Conversation

walterddr
Copy link
Contributor

due to #8491 that changed how ServerInstance is constructed.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

❗ No coverage uploaded for pull request base (multi_stage_query_engine@6ae5f76). Click here to learn what that means.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##             multi_stage_query_engine    #8664   +/-   ##
===========================================================
  Coverage                            ?   70.34%           
  Complexity                          ?     4571           
===========================================================
  Files                               ?     1744           
  Lines                               ?    89540           
  Branches                            ?    13317           
===========================================================
  Hits                                ?    62986           
  Misses                              ?    22221           
  Partials                            ?     4333           
Flag Coverage Δ
integration1 27.40% <0.00%> (?)
integration2 25.59% <0.00%> (?)
unittests1 66.15% <0.00%> (?)
unittests2 15.21% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae5f76...6829531. Read the comment docs.

@siddharthteotia siddharthteotia merged commit c9bebeb into apache:multi_stage_query_engine May 10, 2022
walterddr added a commit to walterddr/pinot that referenced this pull request May 17, 2022
Co-authored-by: Rong Rong <rongr@startree.ai>
walterddr added a commit to walterddr/pinot that referenced this pull request May 24, 2022
Co-authored-by: Rong Rong <rongr@startree.ai>
walterddr added a commit to walterddr/pinot that referenced this pull request Jun 8, 2022
Co-authored-by: Rong Rong <rongr@startree.ai>
walterddr added a commit that referenced this pull request Jun 8, 2022
Co-authored-by: Rong Rong <rongr@startree.ai>
@walterddr walterddr deleted the hot_fix_server_discovery branch December 6, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants